Skip to content

Commit

Permalink
Update to electron 22.3.2
Browse files Browse the repository at this point in the history
The default behaviour of cookies in the electron session has changed and
had to be adjusted accordingly

constributed by STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
  • Loading branch information
tsmaeder committed Mar 16, 2023
1 parent 6f71ec9 commit c9f5860
Show file tree
Hide file tree
Showing 7 changed files with 33 additions and 205 deletions.
2 changes: 1 addition & 1 deletion examples/electron/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,6 @@
},
"devDependencies": {
"@theia/cli": "1.35.0",
"electron": "^15.3.5"
"electron": "^22.3.2"
}
}
2 changes: 1 addition & 1 deletion packages/core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export class SomeClass {

- `@theia/core/electron-shared/...`
- `native-keymap` (from [`native-keymap@^2.2.1`](https://www.npmjs.com/package/native-keymap))
- `electron` (from [`electron@^15.3.5`](https://www.npmjs.com/package/electron))
- `electron` (from [`electron@^22.3.2`](https://www.npmjs.com/package/electron))
- `electron-store` (from [`electron-store@^8.0.0`](https://www.npmjs.com/package/electron-store))
- `fix-path` (from [`fix-path@^3.0.0`](https://www.npmjs.com/package/fix-path))
- `@theia/core/shared/...`
Expand Down
3 changes: 2 additions & 1 deletion packages/core/src/electron-main/electron-api-main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ export class TheiaMainApi implements ElectronMainApplicationContribution {
url: endpoint,
name: ElectronSecurityToken,
value: JSON.stringify(this.electronSecurityToken),
httpOnly: true
httpOnly: true,
sameSite: 'no_restriction'
}));

// application menu
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ export class ElectronSecurityTokenService {
url,
name: ElectronSecurityToken,
value: JSON.stringify(this.electronSecurityToken),
httpOnly: true
httpOnly: true,
sameSite: 'no_restriction'
});
}
}
2 changes: 1 addition & 1 deletion packages/electron/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ The `@theia/electron` extension bundles all Electron-specific dependencies and c

- `@theia/electron/shared/...`
- `native-keymap` (from [`native-keymap@^2.2.1`](https://www.npmjs.com/package/native-keymap))
- `electron` (from [`electron@^15.3.5`](https://www.npmjs.com/package/electron))
- `electron` (from [`electron@^22.3.2`](https://www.npmjs.com/package/electron))
- `electron-store` (from [`electron-store@^8.0.0`](https://www.npmjs.com/package/electron-store))
- `fix-path` (from [`fix-path@^3.0.0`](https://www.npmjs.com/package/fix-path))

Expand Down
2 changes: 1 addition & 1 deletion packages/electron/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"@theia/re-exports": "1.35.0"
},
"peerDependencies": {
"electron": "^15.3.5"
"electron": "^22.3.2"
},
"theiaReExports": {
"shared": {
Expand Down
Loading

0 comments on commit c9f5860

Please sign in to comment.