Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DocumentSymbolProviderMetadata #10026

Closed
Tracked by #9863
tsmaeder opened this issue Sep 1, 2021 · 1 comment · Fixed by #10811
Closed
Tracked by #9863

Implement DocumentSymbolProviderMetadata #10026

tsmaeder opened this issue Sep 1, 2021 · 1 comment · Fixed by #10811
Assignees
@tsmaeder
Labels
good first issue good first issues for new contributors hackathon issues reserved for hackatons outline issues related to the outline vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Sep 1, 2021 •
edited
Loading

Feature Description:

Concretely, there is now a label for the provider. When registering a provider, we should pass this information all the way to the monaco editor. We need to use that label in monaco-outline-contribution.ts

See https://code.visualstudio.com/api/references/vscode-api#DocumentSymbolProviderMetadata
@tsmaeder tsmaeder added vscode issues related to VSCode compatibility outline issues related to the outline good first issue good first issues for new contributors labels Sep 1, 2021
@tsmaeder tsmaeder mentioned this issue Sep 1, 2021
Closed
48 tasks
@tsmaeder tsmaeder added the hackathon issues reserved for hackatons label Dec 8, 2021
@tsmaeder tsmaeder self-assigned this Dec 8, 2021
@tsmaeder
Copy link
Contributor Author

see also languages-main.ts#createDocumentSymbolProvider for where the monaco symbol provider is created.

ndoschek added a commit to eclipsesource/theia that referenced this issue Feb 28, 2022
@ndoschek
eclipse-theia#10026 Implement DocumentSymbolProviderMetadata
3c7c1aa 
- Introduce DocumentSymbolProviderMetadata interface in theia.d.ts
- Adapt register functions to pass on optional metadata
- Adapt the MonacoOutlineContribution and use metadata label or plugin's displayName as root node if multiple providers are registered (aligned to behavior in VSCode)
- Remove Theia's custom DocumentSymbolProvider for 'launch.json' files and reuse VSCode's provider (available via vscode-builtin-configuration-editing)

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <[email protected]>

Fixes eclipse-theia#10026
@ndoschek ndoschek mentioned this issue Feb 28, 2022
Merged
1 task
ndoschek added a commit to eclipsesource/theia that referenced this issue Feb 28, 2022
@ndoschek
eclipse-theia#10026 Implement DocumentSymbolProviderMetadata
e64ea94 
- Introduce DocumentSymbolProviderMetadata interface in theia.d.ts
- Adapt register functions to pass on optional metadata
- Adapt the MonacoOutlineContribution and use metadata label or plugin's displayName as root node if multiple providers are registered (aligned to behavior in VSCode)
- Remove Theia's custom DocumentSymbolProvider for 'launch.json' files and reuse VSCode's provider (available via vscode-builtin-configuration-editing)

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <[email protected]>

Fixes eclipse-theia#10026
ndoschek added a commit to eclipsesource/theia that referenced this issue Mar 1, 2022
@ndoschek
eclipse-theia#10026 Implement DocumentSymbolProviderMetadata
50eda78 
- Introduce DocumentSymbolProviderMetadata interface in theia.d.ts
- Adapt register functions to pass on optional metadata
- Adapt the MonacoOutlineContribution and use metadata label or plugin's displayName as root node if multiple providers are registered (aligned to behavior in VSCode)
- Remove Theia's custom DocumentSymbolProvider for 'launch.json' files and reuse VSCode's provider (available via vscode-builtin-configuration-editing)

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <[email protected]>

Fixes eclipse-theia#10026
msujew pushed a commit that referenced this issue Mar 1, 2022
@ndoschek
#10026 Implement DocumentSymbolProviderMetadata (#10811)
7fd85c0 
- Introduce DocumentSymbolProviderMetadata interface in theia.d.ts
- Adapt register functions to pass on optional metadata
- Adapt the MonacoOutlineContribution and use metadata label or plugin's displayName as root node if multiple providers are registered (aligned to behavior in VSCode)
- Remove Theia's custom DocumentSymbolProvider for 'launch.json' files and reuse VSCode's provider (available via vscode-builtin-configuration-editing)

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <[email protected]>

Fixes #10026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsmaeder tsmaeder

Labels
good first issue good first issues for new contributors hackathon issues reserved for hackatons outline issues related to the outline vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#10026 Implement DocumentSymbolProviderMetadata eclipsesource/theia
1 participant
@tsmaeder