Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] Support optional property TerminalOptions#hideFromUser #11144

Closed
Tracked by #9863
planger opened this issue May 12, 2022 · 1 comment · Fixed by #11630
Closed
Tracked by #9863

[vscode] Support optional property TerminalOptions#hideFromUser #11144

planger opened this issue May 12, 2022 · 1 comment · Fixed by #11630
Labels
terminal issues related to the terminal vscode issues related to VSCode compatibility

Comments

@planger
Copy link
Contributor

planger commented May 12, 2022

Feature Description:

Add support for TerminalOptions#hideFromUser to allow specifying whether the terminal should not be surfaced to the user until Terminal.show is called, see https://code.visualstudio.com/api/references/vscode-api#TerminalOptions.

@vince-fugnitto vince-fugnitto added terminal issues related to the terminal vscode issues related to VSCode compatibility labels May 12, 2022
@planger
Copy link
Contributor Author

planger commented Sep 1, 2022

I'll take a look at this issue.

planger added a commit to eclipsesource/theia that referenced this issue Sep 2, 2022
* Add TerminalOptions.hideFromUser in theia.d.ts
* Add TerminalWidget.hidden
* Fix cwd for created terminals with undefined cwd (default: workspace)

If TerminalOptions.hideFromUser is set to true, the TerminalWidget
will be hidden from any user-facing terminal lists until it is first
explicitly shown to the user (see TerminalWidget.hidden).

As we don't open TerminalWidgets by default on `TerminalService.newTerminal`
and as we don't have a global terminal view (in contrast to VS Code),
we only need to hide it in the `TerminalQuickOpenService` really.

For future evolution, we can rely on the `TerminalService.allVisible` to
determine which terminals to show in any UI.

Contributed on behalf of STMicroelectronics.
Fixes eclipse-theia#11144

Change-Id: Ic1fdf2d5515d5b2fa8feb58b72218b93eeabda4d
planger added a commit to eclipsesource/theia that referenced this issue Sep 15, 2022
* Add TerminalOptions.hideFromUser in theia.d.ts
* Add TerminalWidget.hidden
* Fix cwd for created terminals with undefined cwd (default: workspace)

If TerminalOptions.hideFromUser is set to true, the TerminalWidget
will be hidden from any user-facing terminal lists until it is first
explicitly shown to the user (see TerminalWidget.hidden).

As we don't open TerminalWidgets by default on `TerminalService.newTerminal`
and as we don't have a global terminal view (in contrast to VS Code),
we only need to hide it in the `TerminalQuickOpenService` really.

For future evolution, we can rely on the `TerminalService.allVisible` to
determine which terminals to show in any UI.

Contributed on behalf of STMicroelectronics.
Fixes eclipse-theia#11144

Change-Id: Ic1fdf2d5515d5b2fa8feb58b72218b93eeabda4d
planger added a commit to eclipsesource/theia that referenced this issue Oct 13, 2022
* Add TerminalOptions.hideFromUser in theia.d.ts
* Add TerminalWidget.hiddenFromUser
* Fix cwd for created terminals with undefined cwd (default: workspace)

If TerminalOptions.hideFromUser is set to true, the TerminalWidget
will be hidden from any user-facing terminal lists until it is first
explicitly shown to the user (see TerminalWidget.hiddenFromUser).

As we don't open TerminalWidgets by default on `TerminalService.newTerminal`
and as we don't have a global terminal view (in contrast to VS Code),
we only need to hide it in the `TerminalQuickOpenService` really.

Contributed on behalf of STMicroelectronics.
Fixes eclipse-theia#11144

Change-Id: Ic1fdf2d5515d5b2fa8feb58b72218b93eeabda4d
JonasHelming pushed a commit that referenced this issue Oct 13, 2022
* Add TerminalOptions.hideFromUser in theia.d.ts
* Add TerminalWidget.hiddenFromUser
* Fix cwd for created terminals with undefined cwd (default: workspace)

If TerminalOptions.hideFromUser is set to true, the TerminalWidget
will be hidden from any user-facing terminal lists until it is first
explicitly shown to the user (see TerminalWidget.hiddenFromUser).

As we don't open TerminalWidgets by default on `TerminalService.newTerminal`
and as we don't have a global terminal view (in contrast to VS Code),
we only need to hide it in the `TerminalQuickOpenService` really.

Contributed on behalf of STMicroelectronics.
Fixes #11144

Change-Id: Ic1fdf2d5515d5b2fa8feb58b72218b93eeabda4d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
terminal issues related to the terminal vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants