Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide infrastructure to forward/tunnel a (backend) json-rpc connection to a frontend service #11405

Closed
tortmayr opened this issue Jul 11, 2022 · 0 comments
Closed

Provide infrastructure to forward/tunnel a (backend) json-rpc connection to a frontend service #11405

tortmayr opened this issue Jul 11, 2022 · 0 comments
Labels
messaging issues related to messaging

Comments

@tortmayr
Copy link
Contributor

With the old vscode-jsonrpc based RCP protocol (pre v1.27.0) Theia indirectly offered support for forwarding a (external) json-rpc connection via the backend to a frontend service.
The process was as follows:
(In the backend)

  • Receive a raw json-rpc service connection via MessagingContribution.forward
  • Create a raw json-rpc connection (e.g. via socket to a child server process) with the infrastructure provided by vsocde-ws-jsonrpc
  • Use the vscode-ws-jsonrpcs forward() to forward the service connection to the server connection.

This made it possible to establish a service connection to an external server.
With the change from json-rpc to the new message RPC protocol (#11011 resp. #11228) Theia lost this functionality.
This means all extensions that are using this approach are not longer working with Theia >=1.27.0.
@tortmayr tortmayr mentioned this issue Jul 11, 2022
Closed
@vince-fugnitto vince-fugnitto added the messaging issues related to messaging label Jul 11, 2022
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Jul 11, 2022
@tortmayr
GH-703 Update to Theia 1.27.0
6fb550b 
- Update Theia dependencies to 1.27.0
- Adapt code base to API breaks of 1.27.0
- Implement a temporary workaround for tunneling json-rpc connection until eclipse-theia/theia#11405 is resolved
- Update readmes

Fixes eclipse-glsp/glsp#703

Contributed on behalf of STMicroelectronics
@tortmayr tortmayr mentioned this issue Jul 11, 2022
Merged
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Jul 11, 2022
@tortmayr
GH-703 Update to Theia 1.27.0 (#119)
7f1c788 
* GH-703 Update to Theia 1.27.0

- Update Theia dependencies to 1.27.0
- Adapt code base to API breaks of 1.27.0
- Implement a temporary workaround for tunneling json-rpc connection until eclipse-theia/theia#11405 is resolved
- Update readmes

Fixes eclipse-glsp/glsp#703

Contributed on behalf of STMicroelectronics
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Jul 11, 2022
@tortmayr
v1.0.0-theia1.27.0
256b594 
- Update Theia dependencies to 1.27.0
- Adapt code base to API breaks of 1.27.0
- Implement a temporary workaround for tunneling json-rpc connection until eclipse-theia/theia#11405 is resolved
- Update readmes

Fixes eclipse-glsp/glsp#703

Contributed on behalf of STMicroelectronics
@tortmayr tortmayr closed this as completed Jan 4, 2023
@tortmayr tortmayr mentioned this issue Apr 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
messaging issues related to messaging
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tortmayr @vince-fugnitto