Conflicting declarations in theia.d.ts and theia.proposed.d.ts
#11556
Comments
colin-grant-work
added
quality
|
@martin-fleck-at, since it looks like you added the |
|
@colin-grant-work Sure, I can have a look! |
- Remove very out-dated backwards compatibility to proposed VS Code API -- Get rid of provider id-based API -- Remove deprecated 'hasSession' from API -- Deprecate login/logout (now: createSession/removeSession) in Theia Previously we were compatible with a very specific commit of the proposed authentication API of VS Code 1.53.2. The API was moved from its proposed state to stable with 1.54.0 to which we are fully compatible. Relates to eclipse-theia#11556
|
@colin-grant-work I had a look at the API and I do not think there is a good strategy to get the types proposed API and the stable API compatible. I therefore suggest to get rid of the proposed API since we only were compatible with a very specific commit of the proposed API in VS Code 1.53.2 anyway and therefore never fully compatible with 1.53.2 (see #10709 (comment) and the PR). Our current stable API matches the stable API from VS Code 1.54.0 and higher which I hope will be enough, what do you think? |
|
@martin-fleck-at, I agree. I don't believe VSCode does, and I don't believe we can or should guarantee ongoing compatibility with outdated proposal stages, so if the API has moved on, we should as well. |
|
@colin-grant-work Perfect, I already implemented this in a PR here: #11564 ;-) |
- Remove very out-dated backwards compatibility to proposed VS Code API -- Get rid of provider id-based API -- Remove deprecated 'hasSession' from API -- Deprecate login/logout (now: createSession/removeSession) in Theia Previously we were compatible with a very specific commit of the proposed authentication API of VS Code 1.53.2. The API was moved from its proposed state to stable with 1.54.0 to which we are fully compatible. Relates to #11556
- Remove very out-dated backwards compatibility to proposed VS Code API -- Get rid of provider id-based API -- Remove deprecated 'hasSession' from API -- Deprecate login/logout (now: createSession/removeSession) in Theia Previously we were compatible with a very specific commit of the proposed authentication API of VS Code 1.53.2. The API was moved from its proposed state to stable with 1.54.0 to which we are fully compatible. Relates to #11556
Bug Description:
Steps to Reproduce:
packages/plugin/tsconfig.jsonsetcompilerOptions.skipLibCheck: false.theia.d.tsAuthenticationProviderAuthenticationSessionsChangeEventand observe that TS now points out that the interface is declared with different types intheia.proposed.d.tsAdditional Information
Various other problems are found with
skipLibCheck: false, and straightforward fixes result in build errors in the code.The text was updated successfully, but these errors were encountered: