Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No git status indication in the editor tab #13301

Closed
Tracked by #13192
JonasHelming opened this issue Jan 23, 2024 · 5 comments · Fixed by #13371
Closed
Tracked by #13192

No git status indication in the editor tab #13301

JonasHelming opened this issue Jan 23, 2024 · 5 comments · Fixed by #13371
Assignees

Comments

@JonasHelming
Copy link
Contributor

JonasHelming commented Jan 23, 2024

VSCode colors the file name and adds an indicator on changed files, just like in the navigator. Theia IDE does not:

image

Additional Information

  • Operating System: Ubuntu
  • Theia Version: 1.45
@JonasHelming JonasHelming mentioned this issue Jan 23, 2024
55 tasks
@dhuebner
Copy link
Contributor

dhuebner commented Feb 2, 2024

Note:
This editor tab behavior is configurable in vs-code:
workbench.editor.decorations.badges to control marker/change indicator
workbench.editor.decorations.colors to control tab titel color

@JonasHelming
Copy link
Contributor Author

@dhuebner Are you interested in working on this? This would be a nice addition I think.

@dhuebner
Copy link
Contributor

dhuebner commented Feb 2, 2024

@JonasHelming
I'm interested, yes. But to be honest I am not sure where to start investigating.
It should be a badge contribution from the git extension similar to the explorer view, but I'm not sure.
I will definitely spend some time to find it out and report my findings here.

@dhuebner
Copy link
Contributor

dhuebner commented Feb 2, 2024

@JonasHelming
Now I found it. Thees are tailDecorations that need to be contributed within the ScmTabBarDecorator. I need to check whether the tailDecorations are rendered in the Editors tab bar.

So yes, please assign me.

@dhuebner
Copy link
Contributor

dhuebner commented Feb 9, 2024

@JonasHelming
I got it working, but need to handle all contributed decoration not just SCM.
Now we can also see the problem marker tail decorations, which is good:
Bildschirmfoto 2024-02-09 um 14 04 13

I opened a PR #13371

dhuebner added a commit to dhuebner/theia that referenced this issue Feb 9, 2024
dhuebner added a commit to dhuebner/theia that referenced this issue Feb 9, 2024
dhuebner added a commit to dhuebner/theia that referenced this issue Feb 16, 2024
dhuebner added a commit to dhuebner/theia that referenced this issue Feb 16, 2024
@msujew msujew linked a pull request Feb 21, 2024 that will close this issue
@msujew msujew closed this as completed Feb 21, 2024
This was referenced Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants