Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support vscode theming #4831

Closed
akosyakov opened this issue Apr 8, 2019 · 5 comments · Fixed by #6475
Closed

support vscode theming #4831

akosyakov opened this issue Apr 8, 2019 · 5 comments · Fixed by #6475
Assignees
@akosyakov @jbicker
Labels
enhancement issues that are enhancements to current functionality - nice to haves theming issues related to theming vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

See https://code.visualstudio.com/api/extension-capabilities/theming
@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves vscode issues related to VSCode compatibility labels Apr 8, 2019
@jgbradley1
Copy link
Contributor

I was just reading about themes. From what I understand, if Theia wants to leverage existing VS code themes, then all of the variables referenced in the css files here will require refactoring. Namely, rename the variables and align them to their VS Code equivalent. Then Theia themes could rely on the same theme creation process as VS Code.

@akosyakov
Copy link
Member Author

Something like that, or we will need to have some kind of mapping if we don't want to break.

@akosyakov akosyakov mentioned this issue Jul 19, 2019
Closed
@akosyakov akosyakov mentioned this issue Aug 21, 2019
Closed
4 tasks
@akosyakov akosyakov self-assigned this Aug 21, 2019
@akosyakov akosyakov mentioned this issue Aug 26, 2019
Open
@akosyakov akosyakov added the theming issues related to theming label Aug 26, 2019
@akosyakov akosyakov mentioned this issue Oct 1, 2019
Closed
@jankeromnes jankeromnes mentioned this issue Oct 1, 2019
Closed
@vince-fugnitto vince-fugnitto mentioned this issue Oct 29, 2019
Closed
akosyakov added a commit that referenced this issue Oct 31, 2019
@akosyakov
[theming] #4831: color contribution point
aee7427 
- Theia extensions can register new colors
- All colors are translated into css variables with `.` replaced by `-` and `--theia` prefix
- Theia extensions can use registered colors via css or programatically from `ColorRegistrsy.getCurrentColor`

Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Oct 31, 2019
@akosyakov
[plugin/theming] #4831: load themes from json files
20b7382 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 1, 2019
@akosyakov
[plugin/theming] #4831: load themes from json files
85cf502 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 1, 2019
@akosyakov
[theming] #4831: color contribution point
2f86eed 
- Theia extensions can register new colors
- All colors are translated into css variables with `.` replaced by `-` and `--theia` prefix
- Theia extensions can use registered colors via css or programatically from `ColorRegistrsy.getCurrentColor`

Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 1, 2019
@akosyakov
[theming] #4831: color contribution point
f2660f8 
- Theia extensions can register new colors
- All colors are translated into css variables with `.` replaced by `-` and `--theia` prefix
- Theia extensions can use registered colors via css or programatically from `ColorRegistrsy.getCurrentColor`

Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 1, 2019
@akosyakov
[plugin/theming] #4831: load themes from json files
7f3a220 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 7, 2019
@akosyakov
[theming] #4831: color contribution point
2153c37 
- Theia extensions can register new colors
- All colors are translated into css variables with `.` replaced by `-` and `--theia` prefix
- Theia extensions can use registered colors via css or programatically from `ColorRegistrsy.getCurrentColor`

Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 7, 2019
@akosyakov
[theming] #4831: color contribution point
962531a 
- Theia extensions can register new colors
- All colors are translated into css variables with `.` replaced by `-` and `--theia` prefix
- Theia extensions can use registered colors via css or programatically from `ColorRegistrsy.getCurrentColor`

Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 8, 2019
@akosyakov
[theming] #4831: color contribution point
81318c2 
- Theia extensions can register new colors
- All colors are translated into css variables with `.` replaced by `-` and `--theia` prefix
- Theia extensions can use registered colors via css or programatically from `ColorRegistrsy.getCurrentColor`

Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 11, 2019
@akosyakov
[theming] #4831: color contribution point
8b7beda 
- Theia extensions can register new colors
- All colors are translated into css variables with `.` replaced by `-` and `--theia` prefix
- Theia extensions can use registered colors via css or programatically from `ColorRegistrsy.getCurrentColor`

Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 11, 2019
@akosyakov
[theming] #4831: color contribution point
5a15731 
- Theia extensions can register new colors
- All colors are translated into css variables with `.` replaced by `-` and `--theia` prefix
- Theia extensions can use registered colors via css or programatically from `ColorRegistrsy.getCurrentColor`

Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 11, 2019
@akosyakov
[theming] #4831: color contribution point
3ae256c 
- Theia extensions can register new colors
- All colors are translated into css variables with `.` replaced by `-` and `--theia` prefix
- Theia extensions can use registered colors via css or programatically from `ColorRegistrsy.getCurrentColor`

Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit to akosyakov/theia that referenced this issue Nov 11, 2019
@akosyakov
[theming] eclipse-theia#4831: color contribution point
2a24bd7 
- Theia extensions can register new colors
- All colors are translated into css variables with `.` replaced by `-` and `--theia` prefix
- Theia extensions can use registered colors via css or programatically from `ColorRegistrsy.getCurrentColor`

Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit to akosyakov/theia that referenced this issue Nov 13, 2019
@akosyakov
[theming] eclipse-theia#4831: color contribution point
e00baba 
- Theia extensions can register new colors
- All colors are translated into css variables with `.` replaced by `-` and `--theia` prefix
- Theia extensions can use registered colors via css or programatically from `ColorRegistrsy.getCurrentColor`

Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 13, 2019
@akosyakov
[theming] #4831: color contribution point
3a1ef38 
- Theia extensions can register new colors
- All colors are translated into css variables with `.` replaced by `-` and `--theia` prefix
- Theia extensions can use registered colors via css or programatically from `ColorRegistrsy.getCurrentColor`

Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 13, 2019
@akosyakov
[theming] #4831: color contribution point
8f3ed47 
- Theia extensions can register new colors
- All colors are translated into css variables with `.` replaced by `-` and `--theia` prefix
- Theia extensions can use registered colors via css or programatically from `ColorRegistrsy.getCurrentColor`

Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 14, 2019
@akosyakov
[plugin/theming] #4831: load themes from json files
4a537fd 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 18, 2019
@akosyakov
[theming] #4831: color contribution point
3fec7c7 
- Theia extensions can register new colors
- All colors are translated into css variables with `.` replaced by `-` and `--theia` prefix
- Theia extensions can use registered colors via css or programatically from `ColorRegistrsy.getCurrentColor`

Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 19, 2019
@akosyakov
[theming] #4831: color contribution point
38191e4 
- Theia extensions can register new colors
- All colors are translated into css variables with `.` replaced by `-` and `--theia` prefix
- Theia extensions can use registered colors via css or programatically from `ColorRegistrsy.getCurrentColor`

Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 19, 2019
@akosyakov
[plugin/theming] #4831: load themes from json files
80bf333 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 20, 2019
@akosyakov
[plugin/theming] #4831: load themes from json files
36aa7f5 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 21, 2019
@akosyakov
[theming] #4831: color contribution point
ca9f80b 
- Theia extensions can register new colors
- All colors are translated into css variables with `.` replaced by `-` and `--theia` prefix
- Theia extensions can use registered colors via css or programatically from `ColorRegistrsy.getCurrentColor`

Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 21, 2019
@akosyakov
[theming] #4831: color contribution point
747a0f0 
- Theia extensions can register new colors
- All colors are translated into css variables with `.` replaced by `-` and `--theia` prefix
- Theia extensions can use registered colors via css or programatically from `ColorRegistrsy.getCurrentColor`

Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 21, 2019
@akosyakov
[theming] #4831: color contribution point
82462bf 
- Theia extensions can register new colors
- All colors are translated into css variables with `.` replaced by `-` and `--theia` prefix
- Theia extensions can use registered colors via css or programatically from `ColorRegistrsy.getCurrentColor`

Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 22, 2019
@akosyakov
[theming] #4831: color contribution point
766dfd7 
- Theia extensions can register new colors
- All colors are translated into css variables with `.` replaced by `-` and `--theia` prefix
- Theia extensions can use registered colors via css or programatically from `ColorRegistrsy.getCurrentColor`

Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 22, 2019
@akosyakov
[theming] #4831: color contribution point
a79e328 
- Theia extensions can register new colors
- All colors are translated into css variables with `.` replaced by `-` and `--theia` prefix
- Theia extensions can use registered colors via css or programatically from `ColorRegistrsy.getCurrentColor`

Signed-off-by: Anton Kosyakov <[email protected]>
@benoitf benoitf mentioned this issue Nov 25, 2019
Closed
14 tasks
akosyakov added a commit that referenced this issue Nov 25, 2019
@akosyakov
[plugin/theming] #4831: load themes from json files
58fa60f 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Nov 25, 2019
@akosyakov
[plugin/theming] #4831: load themes from json files
3e1730e 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Dec 4, 2019
@akosyakov
[plugin/theming] #4831: load themes from json files
fa4ab8f 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Dec 4, 2019
@akosyakov
[plugin/theming] #4831: load themes from json files
620dd3f 
Signed-off-by: Anton Kosyakov <[email protected]>
@akosyakov akosyakov mentioned this issue Dec 4, 2019
Merged
54 tasks
@jankeromnes jankeromnes mentioned this issue Dec 9, 2019
Closed
akosyakov added a commit that referenced this issue Dec 17, 2019
@akosyakov
[plugin/theming] #4831: load themes from json files
4303aa1 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Dec 18, 2019
@akosyakov
[plugin/theming] #4831: load themes from json files
9854e62 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Dec 18, 2019
@akosyakov
[plugin/theming] #4831: load themes from json files
39fbc93 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Dec 19, 2019
@akosyakov
[plugin/theming] #4831: load themes from json files
f0ced37 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Dec 20, 2019
@akosyakov
[plugin/theming] #4831: load themes from json files
5e86928 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Dec 20, 2019
@akosyakov
[plugin/theming] #4831: load themes from json files
826f179 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Dec 26, 2019
@akosyakov
[plugin/theming] #4831: load themes from json files
1fe99da 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Dec 27, 2019
@akosyakov
[plugin/theming] #4831: load themes from json files
16c38ce 
Signed-off-by: Anton Kosyakov <[email protected]>
@ghuntley
Copy link

HUGE <3

akosyakov added a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
[theming] eclipse-theia#4831: color contribution point
bf8256c 
- Theia extensions can register new colors
- All colors are translated into css variables with `.` replaced by `-` and `--theia` prefix
- Theia extensions can use registered colors via css or programatically from `ColorRegistrsy.getCurrentColor`

Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
[plugin/theming] eclipse-theia#4831: load themes from json files
947b078 
Signed-off-by: Anton Kosyakov <[email protected]>
@clovis-dugue
Copy link

@akosyakov Hi, I just stumbled upon this issue.

Are product icon themes implemented ? When searching the commands, VSCode provides 2 while Theia only has the "File Icons" commands.
image

VSCode does list it in its capabilities.

Furthermore, I could not find an equivalent to the product icon reference for Theia. Did I miss it ?

@kenneth-marut-work kenneth-marut-work mentioned this issue May 24, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

@jbicker jbicker

Labels
enhancement issues that are enhancements to current functionality - nice to haves theming issues related to theming vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

VS Code like theming (colors and icons) eclipse-theia/theia
5 participants
@ghuntley @jgbradley1 @akosyakov @jbicker @clovis-dugue