Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[keybindings] Allow removal rules in keybindings #5303

Closed
JPinkney opened this issue May 29, 2019 · 1 comment
Closed

[keybindings] Allow removal rules in keybindings #5303

JPinkney opened this issue May 29, 2019 · 1 comment
Assignees
@JPinkney
Labels
keybindings issues related to keybindings vscode issues related to VSCode compatibility

Comments

@JPinkney
Copy link
Contributor

We should support the removal syntax E.g. { "key": "ctrl+3", "command": "-explorer.newFile" } (the - before explorer.newFile) that allows us to remove a specific keybinding.

See: https://code.visualstudio.com/docs/getstarted/keybindings#_removing-a-specific-key-binding-rule
@akosyakov akosyakov added keybindings issues related to keybindings vscode issues related to VSCode compatibility labels May 29, 2019
@JPinkney
Copy link
Contributor Author

I can't assign myself to this issue but this will be fixed in a future PR of mine that aligns theia keybindings behaviour with vscode keybinding behaviour

@JPinkney JPinkney mentioned this issue May 31, 2019
Merged
JPinkney added a commit to JPinkney/theia that referenced this issue Jun 3, 2019
@JPinkney
Fixed eclipse-theia#5303: Aligned keybindings with VSCode
ffa13dd 
Signed-off-by: Josh Pinkney <[email protected]>
JPinkney added a commit to JPinkney/theia that referenced this issue Jun 19, 2019
@JPinkney
Fixed eclipse-theia#5303: Aligned keybindings with VSCode
a249873 
Signed-off-by: Josh Pinkney <[email protected]>
(cherry picked from commit ffa13dd)
JPinkney added a commit to JPinkney/theia that referenced this issue Jun 19, 2019
@JPinkney
Fixed eclipse-theia#5303: Aligned keybindings with VSCode
5ce046e 
Signed-off-by: Josh Pinkney <[email protected]>
@akosyakov akosyakov mentioned this issue Jul 2, 2019
Closed
akosyakov pushed a commit that referenced this issue Jul 2, 2019
@JPinkney @akosyakov
Fixed #5303: Aligned keybindings with VSCode
485cd72 
Signed-off-by: Josh Pinkney <[email protected]>
JPinkney added a commit to JPinkney/theia that referenced this issue Jul 8, 2019
@JPinkney
Fixed eclipse-theia#5303: Aligned keybindings with VSCode
9d50407 
Signed-off-by: Josh Pinkney <[email protected]>
JPinkney added a commit to JPinkney/theia that referenced this issue Jul 8, 2019
@JPinkney
Fixed eclipse-theia#5303. Aligned keybindings with VSCode
2b74fd1 
Signed-off-by: Josh Pinkney <[email protected]>
JPinkney added a commit to JPinkney/theia that referenced this issue Jul 16, 2019
@JPinkney
Fixed eclipse-theia#5303. Aligned keybindings with VSCode
16e7ca4 
Signed-off-by: Josh Pinkney <[email protected]>
kittaakos added a commit that referenced this issue Jul 22, 2019
@kittaakos
Revert "Fixed #5303. Aligned keybindings with VSCode"
7ceb1eb 
This reverts commit 1f9472e.
kittaakos added a commit that referenced this issue Jul 22, 2019
@kittaakos
Revert "Fixed #5303. Aligned keybindings with VSCode"
5b153fa 
This reverts commit 1f9472e.

Reverts #5326.
Closes #5749.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Jul 23, 2019
Revert "Fixed #5303. Aligned keybindings with VSCode"
dd51244 
This reverts commit 1f9472e.

Reverts #5326.
Closes #5749.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Jul 23, 2019
@kittaakos
Revert "Fixed #5303. Aligned keybindings with VSCode"
5137616 
This reverts commit 1f9472e.

Reverts #5326.
Closes #5749.

Signed-off-by: Akos Kitta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JPinkney JPinkney

Labels
keybindings issues related to keybindings vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Aligned keybindings with VSCode eclipse-theia/theia
2 participants
@akosyakov @JPinkney