[quality] Use one lib for debounce.

[kittaakos]

Bug Description:

Currently, we use more than one lib for debouncing:

• theia/packages/debug/src/browser/debug-configuration-manager.ts

  Line 22 in f8bcc19

  import debounce = require('p-debounce');

• theia/packages/core/src/browser/common-frontend-contribution.ts

  Line 19 in f8bcc19

  import debounce = require('lodash.debounce');

Pick one and use that.

Steps to Reproduce:

Additional Information

• Operating System:
• Theia Version:

[vince-fugnitto]

I marked the issue as good first issue, if anyone would like to pick it up and needs some help please don't hesitate to ask :)

[123MayankSharma]

I marked the issue as good first issue, if anyone would like to pick it up and needs some help please don't hesitate to ask :)

Hello @vince-fugnitto ! I am new to open source world so would it be okay for me to take up this issue? Are there some prerequisites or guidelines that i should know before starting? It would be a great help if you can help me regarding this!

[vince-fugnitto]

@123MayankSharma sure you can pick up the issue 👍

You can reference our readme for all information regarding building, and contributing, it should provide you with the information you need to contribute the change. Please feel free to ask any questions along the way as well:

• https://github.com/eclipse-theia/theia/blob/master/doc/Developing.md#prerequisites
• https://github.com/eclipse-theia/theia/blob/master/CONTRIBUTING.md

[123MayankSharma]

@123MayankSharma sure you can pick up the issue

You can reference our readme for all information regarding building, and contributing, it should provide you with the information you need to contribute the change. Please feel free to ask any questions along the way as well:

• https://github.com/eclipse-theia/theia/blob/master/doc/Developing.md#prerequisites
• https://github.com/eclipse-theia/theia/blob/master/CONTRIBUTING.md

Thanks a lot for the super quick reply! the help is really appreciated and hope to resolve this issue soon!

[JonasHelming]

@vince-fugnitto : I believe this is actually fixed, do you agree?

[vince-fugnitto]

@vince-fugnitto : I believe this is actually fixed, do you agree?

@JonasHelming can you clarify why believe it is currently fixed, afaik we still make use of both debounce libraries:

p-debounce:

 $ yarn why p-debounce
yarn why v1.22.4
[1/4] Why do we have the module "p-debounce"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "[email protected]"
info Reasons this module exists
   - "_project_#@theia#core" depends on it
   - Hoisted from "_project_#@theia#core#p-debounce"
   - Hoisted from "_project_#@theia#debug#p-debounce"
   - Hoisted from "_project_#@theia#preferences#p-debounce"
   - Hoisted from "_project_#@theia#scm#p-debounce"
   - Hoisted from "_project_#@theia#task#p-debounce"
   - Hoisted from "_project_#@theia#vsx-registry#p-debounce"
info Disk size without dependencies: "20KB"
info Disk size with unique dependencies: "20KB"
info Disk size with transitive dependencies: "20KB"
info Number of shared dependencies: 0
Done in 1.75s.

lodash.debounce:

$ yarn why lodash.debounce
yarn why v1.22.4
[1/4] Why do we have the module "lodash.debounce"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "[email protected]"
info Reasons this module exists
   - "_project_#@theia#core" depends on it
   - Hoisted from "_project_#@theia#core#lodash.debounce"
   - Hoisted from "_project_#@theia#application-manager#@babel#plugin-transform-runtime#babel-plugin-polyfill-corejs2#@babel#helper-define-polyfill-provider#lodash.debounce"
info Disk size without dependencies: "24KB"
info Disk size with unique dependencies: "24KB"
info Disk size with transitive dependencies: "24KB"
info Number of shared dependencies: 0
Done in 1.12s.

I however believe that the issue is likely not as critical as first thought, both libraries do things differently and handle different use-cases (async vs sync for example).

[JonasHelming]

I was just looking at smart-bo#1, but I misunderstood that apparently