Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect completion icon for snippets that come from LSP server #9882

Closed
AirSeeker opened this issue Aug 11, 2021 · 2 comments · Fixed by #9908
Closed

Incorrect completion icon for snippets that come from LSP server #9882

AirSeeker opened this issue Aug 11, 2021 · 2 comments · Fixed by #9908
Labels
monaco issues related to monaco vscode issues related to VSCode compatibility

Comments

@AirSeeker
Copy link

Bug Description:

After the update of Monaco in Theia 1.16.0, the icon for snippets that come from the LSP server is incorrect.
The icon for snippets that come from JSON configurations of plugins is correct.

Incorrect
image

Correct icon
image
https://code.visualstudio.com/docs/editor/userdefinedsnippets#_builtin-snippets

Looks like in file packages/plugin-ext/src/common/plugin-api-rpc-model.ts:144 there missing two types
image
node_modules@theia\monaco-editor-core\monaco.d.ts:5601
image

Steps to Reproduce:

  1. Remove all plugins except vscode-builtin-html and vscode-builtin-html-language-features
  2. Run Theia and create an HTML file.
  3. Hit CTRL + Space to trigger completion from the LSP server.

Additional Information

  • Operating System: Windows
  • Theia Version: 1.16.0
@vince-fugnitto
Copy link
Member

@AirSeeker thank you for reporting the issue, are you interested in contributing a pull-request to fix the icon?

@vince-fugnitto vince-fugnitto added monaco issues related to monaco vscode issues related to VSCode compatibility labels Aug 11, 2021
AirSeeker pushed a commit to AirSeeker/theia that referenced this issue Aug 14, 2021
[eclipse-theiaGH-9882] Add missing completion kind for monaco in plug…
2121c35 
…in-api-rpc-model.ts

Signed-off-by: Petro Dzyuba <[email protected]>
@AirSeeker AirSeeker mentioned this issue Aug 14, 2021
Merged
1 task
@AirSeeker
Copy link
Author

@vince-fugnitto Add PR #9908

vince-fugnitto pushed a commit that referenced this issue Aug 16, 2021
@vince-fugnitto
[GH-9882] Add missing completion kind for monaco in plugin-api-rpc-mo…
1dbed43 
…del.ts

Signed-off-by: Petro Dzyuba <[email protected]>
dna2github pushed a commit to dna2fork/theia that referenced this issue Aug 25, 2021
@dna2github
[eclipse-theiaGH-9882] Add missing completion kind for monaco in plug…
e25d559 
…in-api-rpc-model.ts

Signed-off-by: Petro Dzyuba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
monaco issues related to monaco vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[eclipse-theiaGH-9882] Add missing completion kind for monaco in plugin AirSeeker/theia
2 participants
@AirSeeker @vince-fugnitto