[playwright] Improve getting started documentation #11094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires eclipse-theia/theia-playwright-template#1 Fixes eclipse-theia#11015 Change-Id: I5838de12b7e3e840e354e8230a35c752c9f25dd1 Signed-off-by: Philip Langer <[email protected]>
vince-fugnitto
added
documentation
JonasHelming
requested changes
May 5, 2022
|
|
||
| ## Adding further tests | ||
|
|
||
| Let's write a system test for the Theia text editor as an example: | ||
| Let's write add another system test for the Theia text editor as an example: |
There was a problem hiding this comment.
write or add
please remove one of the words
There was a problem hiding this comment.
Nice catch! Thanks! Fixed in 4bedc18
JonasHelming
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Improves the documentation for getting started with the theia-playwright page object library.
This change requires eclipse-theia/theia-playwright-template#1
And fixes #11015
How to test
Please read
examples/playwright/docs/GETTING_STARTED.mdand follow the steps in order to evaluate whether this guide will help newcomers to get started easily.Review checklist
Reminder for reviewers