vscode: add hcLight support

[vince-fugnitto]

What it does

Fixes: #11314.
The pull-request adds support for high contrast light themes and includes the following updates:

• adds support for hcLight themes
• updates our color registrations to include hcLight based on values present in vscode
• updates our change color theme command to support hcLight and adds localizations

How to test

1. include the following test theme theia-hclight-0.0.2.zip
2. start the application
3. execute the command Preferences: Color Theme - the high contrast light themes should be under high contrast, selecting Test High Contrast Light Theme should work
4. the new High Contrast Light (Theme) should also work

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: vince-fugnitto [email protected]

[msujew]

The changes looks quite good. I noticed just two minor issues (which might have been partially introduced by me, but weren't noticeable using just the dark high contrast theme). Do you mind taking care of those with your PR?

Tabbar colors:
vscode

theia

Focused notifications:
vscode

theia

[vince-fugnitto]

@msujew sure, do you know what the color names are, I wasn't able to find them or identify what might be wrong.

[vince-fugnitto]

I noticed issues when setting Github Dark High Contrast as a theme so more work is needed.

[msujew]

@vince-fugnitto For the notification it should be list.focusBackground and for the tab bar its editorGroupHeader.tabsBorder. Note that there seems to be some conditional logic attached for both (1 and 2).

[vince-fugnitto]

I've opened the issue #11616 regarding the top border, it seems to be a bug also present on master.

[msujew]

@vince-fugnitto Ah, I actually didn't talk about the top border of the tab bar, but rather the slim bar that separates the tabs from the widget area (blue in Theia currently, should be black, see screenshots above).

[msujew]

Coming back to this: I'm actually in favor of merging it now and fixing any possible issues (i.e. missing/incorrectly used colors, etc.) in follow up PRs.

[vince-fugnitto]

I noticed some issues with the support so I'll address them.

[vince-fugnitto]

The changes depend on #11589 to be able to use the hc-light monaco.editor.BuiltinTheme.

[vince-fugnitto]

@msujew I've come back to the pull-request after the monaco uplift and we benefited from proper support for hc-light. I've included a plugin to test against that makes use of hcLight.

Cool, I'll re-review this on Monday :)

[vince-fugnitto]

I've rebased the changes on the latest master 👍

[msujew]

Looks good to me 👍