If evaluate request fails, ignore variable #11928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-grant-work
added
the
memory-inspector
colin-grant-work
force-pushed
the
bugfix/evaluation-failure-crashes-memory
branch
from
8d0a2f2
to
e110d8c
Compare
colin-grant-work
force-pushed
the
bugfix/evaluation-failure-crashes-memory
branch
from
e110d8c
to
dd96271
Compare
paul-marechal
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR addresses a problem where failure to evaluate a variable, for example because that variable has been optimized out, causes the entire sequence of memory retrieval to fail.
How to test
... to be continued
Review checklist
Reminder for reviewers