Add support for SnippetTextEdit vscode API
#12047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
changed the title
SnippetTextEdit vscode API
msujew
reviewed
Jan 10, 2023
includiing support in WorkspaceEdit Signed-off-by: Jonah Iden <[email protected]>
when not inserting as SnippetTextEdit Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
jonah-iden
force-pushed
the
jiden/SnippetTextEdit-vscode-api-12022
branch
from
d897fea
to
85c4cc3
Compare
Signed-off-by: Jonah Iden <[email protected]>
msujew
reviewed
Jan 11, 2023
Signed-off-by: Jonah Iden <[email protected]>
msujew
reviewed
Jan 11, 2023
Co-authored-by: Mark Sujew <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
|
@msujew Do you want to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes: #12022
as described here this PR implements SnippetTextEdits the same way they are implemented in vscode. This adds the api to set them on Workspaceedits and sends them as TextEdits with the insertAsSnippet flag to the monaco editor.
Through the snippetController2 class those Edits can be applied to the current editor.
Should SnippetTextEdits be done on a file which editor is not currently active, they are transformed to just the text and applied as normal TextEdits.
It sadly seems both in vscode and theia this snippetTextEdit/SnippetController2 only supports snippets with a single tabstop. So tabbing through seems to not work yet in both IDEs.
How to test
I built a tiny vscode extension which is downloadable from here
snippet-text-edit-test-0.0.1.zip
or buildable from here https://github.com/jonah-iden/snippet-text-edit-test.
This just inserts a test snippetTextEdit at the start of the currently open file and a file called file2.json in the workspace root (this file needs to be created manually first).
you should see the snippet is inserted correctly at the start of the file and the cursor is moved to the tabstop and in file2.json its also inserted at the start of the file without moving the cursor.
Review checklist
Reminder for reviewers