Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed debug hover widget overflowing when content tree is too big #12058

Merged
merged 2 commits into from
Jan 16, 2023
Merged

fixed debug hover widget overflowing when content tree is too big #12058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
499deff
fixed debug hover widget overflowing when tree to big
jonah-iden Jan 11, 2023
d68ec9c
linting issues fixed
jonah-iden Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/debug/src/browser/editor/debug-hover-widget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ export class DebugHoverWidget extends SourceTreeWidget implements monaco.editor.
this.contentNode.className = 'theia-debug-hover-content';
this.domNode.appendChild(this.contentNode);

// for stopping scroll events from contentNode going to the editor
this.contentNode.addEventListener('wheel', e => e.stopPropagation());

this.editor.getControl().addContentWidget(this);
this.source = this.hoverSource;
this.toDispose.pushAll([
Expand Down
2 changes: 1 addition & 1 deletion packages/debug/src/browser/style/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@

/** Hover */
.theia-debug-hover {
display: flex;
display: flex !important;
flex-direction: column;
border: 1px solid var(--theia-editorHoverWidget-border);
background: var(--theia-editorHoverWidget-background);
Expand Down