Save changes before closing interaction.

[emilhammarstedtst]

What it does

• Question to save all changes, cancel or discard all changes before closing
• Display what is not yet saved.
• Reorder options and reword the question and options to be clear of the outcome of each action
• Implemented using ConfirmDialogSave extending ConfirmDialog

How to test

Electron build of theia and make one or more editors dirty then click the "X" to close the theia window. the popup should appear with a question to save.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

Contributed by STMicroelectronics

[vince-fugnitto]

@emilhammarstedtst thank you for the contribution 👍

I have some general comments about the dialog, mainly to align with the one present in VS Code and re-use some already existing localizations.

I believe that it is incorrect to default to the "Quit Without Saving" button which is selected by default. Pressing Enter should probably Save All instead similarly to VS Code.

---

Please also be sure to properly fill out the pull-request description with "How To Test", for example I don't believe these changes apply to the browser as you have them today?

[emilhammarstedtst]

@emilhammarstedtst thank you for the contribution +1

I have some general comments about the dialog, mainly to align with the one present in VS Code and re-use some already existing localizations.

I believe that it is incorrect to default to the "Quit Without Saving" button which is selected by default. Pressing Enter should probably Save All instead similarly to VS Code.

Please also be sure to properly fill out the pull-request description with "How To Test", for example I don't believe these changes apply to the browser as you have them today?

Amended the commit with your suggestions and cleared up the "undefined"-leftover.
However the title now potentially has the the text " following 0 files?", so i created a fallback case for this.

I dont believe the browser is in question as it is bound to use the onbeforeunload method?

[msujew]

Looks good to me 👍 I have 2 minor comments before merging though.

[vince-fugnitto]

@msujew do we want to merge for today's release?