Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically generate plugin activation events #12167

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

msujew
Copy link
Member

@msujew msujew commented Feb 9, 2023

What it does

Closes #12161

When loading a plugin, this change automatically deduces some of its activation events from the plugin manifest.

This change also adds a few more entries to the manifest types, which were required for this to work correctly.

I also did a drive-by cleanup of the scanner-theia file. A lot of the non-null assertions were no longer required due to advancements of TypeScript type checker.

How to test

  1. Download and install this test extension. The extension is the default hello world extension from vscode, with all of its activationEvents removed.
  2. Run the Hello World command
  3. Assert that the extension starts and a notification is displayed.

Review checklist

Reminder for reviewers

@msujew msujew added the plug-in system issues related to the plug-in system label Feb 9, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good and well for me 👍

  • confirmed that the "hello world" plugin is correctly activated
  • confirmed that existing plugins (ex: builtins) are still activated properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infer plugin activation events from contributions
2 participants