Implement WorkspaceEditMetadata and add new preference for autosave on refactoring
#12193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve on refactorings Signed-off-by: Jonah Iden <[email protected]>
msujew
changed the title
WorkspaceEditMetadata and add new preference for autosave on refactoring
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
msujew
reviewed
Feb 21, 2023
Signed-off-by: Jonah Iden <[email protected]>
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
resolves #12018
this implements
WorkspaceEditMetadatafor the vscode api and adds "files.refactoring.autoSave" as a new preference for autosaving all affected files after applying a refactoring, when normal autosave is disabled and the refactoring is marked as such throughWorkspaceEditMetadata.How to test
You can find a test extension here: https://github.com/jonah-iden/workspace-metadata-test
or download it here: workspace-metadata-test-0.0.1.zip
steps to test
files.autoSavetooff,files.refactoring.autoSaveshould be true by defaultapply workspaceEdit with refactoring. See files should have been saved since the edit was marked as refactoring.apply workspaceEdit without refactoring. Edit should have been applied but files should have not been savedReview checklist
Reminder for reviewers