Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recursive webview-view title setter #12221

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Fix recursive webview-view title setter #12221

merged 1 commit into from
Feb 27, 2023

Conversation

msujew
Copy link
Member

@msujew msujew commented Feb 24, 2023

What it does

Closes #12178

How to test

I haven't prepared a test extension for this, but I assume the changes are simple enough as they are to not require a manual test.

Review checklist

Reminder for reviewers

@msujew msujew added the webviews issues related to webviews label Feb 24, 2023
@vince-fugnitto vince-fugnitto mentioned this pull request Feb 27, 2023
Closed
1 task
vince-fugnitto
vince-fugnitto approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@msujew msujew merged commit 6a7a92b into master Feb 27, 2023
@msujew msujew deleted the msujew/fix-recursive-title-set branch February 27, 2023 14:53
@github-actions github-actions bot added this to the 1.36.0 milestone Feb 27, 2023
federicobozzini pushed a commit to ARMmbed/theia that referenced this pull request Jun 13, 2023
@msujew @federicobozzini
Fix recursive webview-view title setter (eclipse-theia#12221)
861cd0c
erezmus pushed a commit to ARMmbed/theia that referenced this pull request Jun 15, 2023
@msujew @erezmus
Fix recursive webview-view title setter (eclipse-theia#12221)
d69cfcc
erezmus pushed a commit to ARMmbed/theia that referenced this pull request Jun 19, 2023
@msujew @erezmus
Fix recursive webview-view title setter (eclipse-theia#12221)
9b0b6f3
CareyJWilliams pushed a commit to ARMmbed/theia that referenced this pull request Jun 22, 2023
@msujew @CareyJWilliams
Fix recursive webview-view title setter (eclipse-theia#12221)
06a6bf9
CareyJWilliams pushed a commit to ARMmbed/theia that referenced this pull request Jun 23, 2023
@msujew @CareyJWilliams
Fix recursive webview-view title setter (eclipse-theia#12221)
e0899a2
erezmus pushed a commit to ARMmbed/theia that referenced this pull request Aug 2, 2023
@msujew @erezmus
Fix recursive webview-view title setter (eclipse-theia#12221)
61e6f06
erezmus pushed a commit to ARMmbed/theia that referenced this pull request Sep 4, 2023
@msujew @erezmus
Fix recursive webview-view title setter (eclipse-theia#12221)
25d25a0
erezmus pushed a commit to ARMmbed/theia that referenced this pull request Sep 12, 2023
@msujew @erezmus
Fix recursive webview-view title setter (eclipse-theia#12221)
79e7580
erezmus pushed a commit to ARMmbed/theia that referenced this pull request Sep 21, 2023
@msujew @erezmus
Fix recursive webview-view title setter (eclipse-theia#12221)
7ac547a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
webviews issues related to webviews
Projects
None yet
Milestone
1.36.0
Development

Successfully merging this pull request may close these issues.

Unintended recursive set of title
2 participants
@msujew @vince-fugnitto