monaco: quick input regression fix

[FernandoAscencio]

What it does

Fixes a regression introduced in #12095

How to test

Currently the commit in #12095 introduced an regression with some menus did not display properly.

To test, you can run the Start Debugging while on Attach by Process ID. Then check that the display is fixed and no other displays have broken.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[colin-grant-work]

A definite improvement 👍

[vince-fugnitto]

There are issues when we have the seti icon-theme set and attempt to quick-open files:

[FernandoAscencio]

This should address the issues brought in #12247

[colin-grant-work]

These changes appear to address the problems in the three problem areas that have been identified in testing this and related changes: long paths, multi-line picks (attach by process ID), and check marks for toggled commands.

[gbodeen]

The text alignment is fixed ✅
The icon sizing is still mismatched:

[gbodeen]

This doesn't necessarily have to be part of this MR (though a fix was included in !12247) -- if not included, we should open an issue for it.

In light themes, the path is no longer easily distinguished from the filename as in VSCode:

[tsmaeder]

@colin-grant-work do we want to merge this one ahead of the release?

[tsmaeder]

@gbodeen @vince-fugnitto what's the state on this one? We have a 👍 , but it's not merged.

[vince-fugnitto]

@FernandoAscencio the changes look good to me, do you mind updating this value to 0.9 similarly to VS Code. It should help better differentiate between the primary label and item descriptions (for example: when displaying multi-root paths for the quick-file open):

theia/packages/monaco/src/browser/style/index.css

Line 178 in e9cd687

font-size: calc(var(--theia-ui-font-size1) * 0.95) !important;

[FernandoAscencio]

@vince-fugnitto
Changed 0.95 to 0.9.

[vince-fugnitto]

The changes are a nice improvement 👍 and fix the regressions.