workspace: update add and remove folder handling #12242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit removes the unecessary `preferences.ready` handling when registering the `add` and `remove` folder commands as we no longer support the `supportMultiRootWorkspace` preference. The changes should make it easier for downstream to unregister the command if necessary. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
added
quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request removes the now unnecessary preferences ready event listener when registering the commands
ADD_FOLDERandREMOVE_FOLDER. The listener is no longer necessary as the framework no longer supports theworkspace.supportMultiRootWorkspacepreference which required the additional logic.The change should more easily allow downstream extenders/adopters the possibility of unregistering the command if necessary.
How to test
Review checklist
Reminder for reviewers