Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vscode builtin extensions v1.70.2 #12283

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Conversation

marcdumais-work
Copy link
Contributor

@marcdumais-work marcdumais-work commented Mar 10, 2023

What it does

Some time between 1.66.2 and 1.70.2, the references-view extension "ms-vscode.references-view" has gone from a standalone extension, that has its own repository, to a vscode built-in extension, that's part of the vscode repository. With that change, the extension's publisher has been updated from "ms-vscode" to "vscode". As of 1.70.2, this extension is referenced in the builtins extension pack and no longer needs to be specifically referenced in package,json.

This PR contains the following:
Example application:

  • update the builtin extension pack to v1.70.2
  • remove entry for old references-view extension, add it to "theiaPluginsExcludeIds"
  • remove pinning for typescript extensions.

typescript browser tests:

  • use new publisher when referencing references-view builtin
  • re-try sending "Escape" to close the peek widget if it remains opened

How to test

Note: This PR is expected to fail CI until the vscode builtins v1.70.2 are published to openvsx.org. Once that's done, we should be able to fetch the new builtin pack and the extensions it refers-to, including the recently renamed vscode.references-view extension, using yarn download:plugins.

To test:

  • build the repo and example application
  • verify that the new builtins seem to work ok (at least the important ones like typescript, ...)
  • verify that CI passes

Review checklist

Reminder for reviewers

@marcdumais-work marcdumais-work added test issues related to unit and api tests builtins Issues related to VS Code builtin extensions labels Mar 10, 2023
@marcdumais-work marcdumais-work force-pushed the use-builtins-1.70.2 branch 2 times, most recently from 3fa2181 to 72a2bf9 Compare March 10, 2023 17:24
@marcdumais-work marcdumais-work force-pushed the use-builtins-1.70.2 branch 5 times, most recently from 0b15ddf to 25f1cdd Compare March 10, 2023 19:57
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I think we should wait till v1.70.2 is published else we will download both ms-vscode.references-view and vscode.references-view.

@ccorn
Copy link

ccorn commented Mar 13, 2023

The extension pack 1.70.2 bundles both ms-vscode.references-view and vscode.references-view.
Is that a bug?
If so, should ms-vscode.references-view be added to theiaPluginsExcludeIds?

@marcdumais-work
Copy link
Contributor Author

The extension pack 1.70.2 bundles both ms-vscode.references-view and vscode.references-view. Is that a bug? If so, should ms-vscode.references-view be added to theiaPluginsExcludeIds?

Indeed - I accidentally forgot to update the script that creates the extension pack, when I published the builtins v1.70.2 (it will be for the next release). I am doing the change you suggest, as we speak.

Some time between 1.66.2 and 1.70.2, the references-view extension
"ms-vscode.references-view" has gone from a standalone extension,
that has its own repository, to a vscode built-in extension, that's
part of the vscode repository. With that change, the extension's
publisher has been updated from "ms-vscode" to "vscode". As of
1.70.2, this extension is referenced in the builtins extension pack
and no longer needs to be specifically referenced in `package.json`.

This PR contains the following:

Example application:
- update the builtin extension pack to v1.70.2
- remove entry for old `references-view` extension, add it to
  "theiaPluginsExcludeIds"
- remove pinning for typescript extensions.

typescript browser tests:
- use new publisher when referencing `references-view` builtin
- re-try sending "Escape" to close the peek widget if it remains opened

Signed-off-by: Marc Dumais <[email protected]>
@marcdumais-work
Copy link
Contributor Author

LGTM +1

I think we should wait till v1.70.2 is published else we will download both ms-vscode.references-view and vscode.references-view.

@vince-fugnitto builtins 1.70.2 are published. I have added an entry in theiaPluginsExcludeIds to exclude the old name for the references extension, so that only the new version will be present.

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
I no longer see the duplicate "find all references" functionality present in the example applications.

@marcdumais-work marcdumais-work merged commit c7ca0d5 into master Mar 13, 2023
@marcdumais-work marcdumais-work deleted the use-builtins-1.70.2 branch March 13, 2023 17:40
@github-actions github-actions bot added this to the 1.36.0 milestone Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins Issues related to VS Code builtin extensions test issues related to unit and api tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants