terminal: add context menu #12326
Merged
terminal: add context menu #12326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/terminal/src/browser/terminal-frontend-contribution.ts
Outdated
Show resolved
Hide resolved
packages/terminal/src/browser/terminal-frontend-contribution.ts
Outdated
Show resolved
Hide resolved
planger
force-pushed
the
planger/issues/7632
branch
from
306e8fa
to
713824b
Compare
vince-fugnitto
approved these changes
Mar 22, 2023
planger
force-pushed
the
planger/issues/7632
branch
from
713824b
to
9165ff3
Compare
Contributed on behalf of STMicroelectronics. Fixes eclipse-theia#7632 Change-Id: Icb23f6fbdc44cdc5e018277e44ed5fe46c8ac26a
planger
force-pushed
the
planger/issues/7632
branch
from
9165ff3
to
c246077
Compare
|
c246077 rebases on top of current master to resolve conflicts |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Adds a context menu to the terminal widget that covers roughly the same menu items as VS Code.
Therefore, this change also creates the two new commands Select All and Kill Terminal.
Fixes #7632
Contributed on behalf of STMicroelectronics.
Change-Id: Icb23f6fbdc44cdc5e018277e44ed5fe46c8ac26a
How to test
Open a terminal and try out all context menu items (list see above).
It may be worth making sure that the commands also work when triggered via the command palette.
Review checklist
Reminder for reviewers