Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seach-In-Workspace: Include/Exclude Inputbox placeholder #12389

Conversation

FernandoAscencio
Copy link
Contributor

What it does

This commit implements the include and exclude inputbox placeholder.

How to test

  1. Run Theia
  2. Go to the search tab
  3. Focus on an include or exclude inputbox
  4. Check the placeholder text appears

SIW-IncludeExclude-placeholder

Review checklist

Reminder for reviewers

FernandoAscencio and others added 2 commits April 10, 2023 10:51
This commit implements the include and exclude inputbox placeholder.

Signed-Off-By: FernandoAscencio <[email protected]>
@vince-fugnitto vince-fugnitto added search in workspace issues related to the search-in-workspace ui/ux issues related to user interface / user experience labels Apr 10, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vince-fugnitto vince-fugnitto merged commit 8f0755d into eclipse-theia:master Apr 10, 2023
@vince-fugnitto vince-fugnitto deleted the fa/Include-Exclude-placeholder branch April 10, 2023 16:52
@paul-marechal paul-marechal added this to the 1.37.0 milestone Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
search in workspace issues related to the search-in-workspace ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants