Fix memory leak in DockPanelRenderer and ToolbarAwareTabBar #13327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DockerPanelRenderer was not disposing the core preference listener. The ToolbarAwareTabBar was not disposing the TabBarToolbar. Signed-off-by: Vivien Jovet <[email protected]>
msujew
approved these changes
Feb 1, 2024
This was referenced Feb 29, 2024
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR fixes a memory leak occurring in the
DockPanelRendererandToolbarAwareTabBarwhen the user opened and closed a lot of tabs repeatedly. TheDockPanelRendererwas not disposing the core preferences listener when theToolbarAwareTabBaris disposed and theToolbarAwareTabBaritself didn't dispose theTabBarToolbarwhen it is detached.Fixes #13323
How to test
I've added a playwright test to test this issue in "/examples/playwright/src/tests/theia-application-shell.test.ts". Just remove the
skipand run the test then check the logs for memory leak warnings.Review checklist
Reminder for reviewers