Improves style and titles of toolbar items in notebooks. #13334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
reviewed
Feb 1, 2024
packages/notebook/src/browser/contributions/notebook-actions-contribution.ts
Outdated
Show resolved
Hide resolved
jbicker
force-pushed
the
jbicker/improve-notebook-toolbar
branch
from
1fe4a9d
to
78e0f67
Compare
jbicker
force-pushed
the
jbicker/improve-notebook-toolbar
branch
from
78e0f67
to
d9d804b
Compare
Signed-off-by: Jan Bicker <[email protected]>
jbicker
force-pushed
the
jbicker/improve-notebook-toolbar
branch
from
d9d804b
to
24f3039
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
As adressed in #12863 it improves the style and tooltips of the toolbar items in notebooks.
How to test
Follow the "How to test" instructions here and hover toolbar items and experience the amazing look of rounded corners and see that the tooltips are same as in VSCode.
Review checklist
Reminder for reviewers