Support workspace.save(URI) and workspace.saveAs(URI) #13393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes eclipse-theia#13352 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <[email protected]>
|
Here's the plugin: And here's the source: |
Signed-off-by: Thomas Mäder <[email protected]>
rschnekenbu
approved these changes
Feb 20, 2024
This was referenced Feb 29, 2024
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #13352
Contributed on behalf of STMicroelectronics
How to test
The attached vsix contributes two actions "Save current editor" and "Save As current editor". They invoke "save" and "saveAs" on the currently opened editor and displays the resulting uri. Note that in contrast to VS Code, Theia does not documents as "saveable" if they are not dirty, therefore a save on a clean document will not succeed. Check that the behaviour is correct in various scenarios.
Follow-ups
Review checklist
Reminder for reviewers