Fix programmatic save for custom text editors #13684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
added
vscode
msujew
changed the title
msujew
force-pushed
the
msujew/fix-custom-editor-saving
branch
from
b4f39c4
to
7a115fb
Compare
jonah-iden
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #9230
Instead of using the
EditorManager(that seemingly doesn't keep track ofCustomEditorWidgetinstances), we simply use the monaco model service to save the underlying model.Also removes an unused RPC method
$tryCloseDocument.How to test
Follow the instructions in #9230 and confirm that manual saving works as expected. Alternatively, the extension in #12979 should now also work as expected.
Review checklist
Reminder for reviewers