Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] Stub activeStackItem and related change event in debug namespace #13847

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

rschnekenbu
Copy link
Contributor

What it does

Stubs the new API on debug namespace about activeStackItem and event when this value is changed.

fixes #13758

contributed on behalf of STMicroelectronics

How to test

  1. Launch master theia browser example, install the following extension
  1. When starting the example, a message will be logged in the debug console: Activating extension 'debug-extension-sample' failed: TypeError: vscode.debug.onDidChangeActiveStackItem is not a function
  2. With the PR and the extension, no message is logged in the debug console. The extension is supposed to log in the console in case of selection change in the debug views, but obviously does nothing currently due to stub implementation

Follow-ups

The current stub may be replaced by the real implementation. See #13846

Review checklist

Reminder for reviewers

@rschnekenbu rschnekenbu changed the title [vscode] Stub DebugThread and DebugStackFrame [vscode] Stub activeStackItem and related change event in debug namespace Jun 26, 2024
fixes eclipse-theia#13758

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <[email protected]>
@rschnekenbu rschnekenbu marked this pull request as ready for review June 26, 2024 11:34
@rschnekenbu rschnekenbu mentioned this pull request Jun 26, 2024
2 tasks
@rschnekenbu rschnekenbu added the vscode issues related to VSCode compatibility label Jun 26, 2024
@rschnekenbu rschnekenbu merged commit 63c0684 into eclipse-theia:master Jun 27, 2024
14 checks passed
@rschnekenbu rschnekenbu deleted the issues/13758 branch June 27, 2024 08:46
@jfaltermeier jfaltermeier added this to the 1.51.0 milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[vscode] Stub DebugStackFrame and DebugThread API
3 participants