Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: "core.saveAll" command shall only save dirty widgets #13942

Merged

Conversation

KR155E
Copy link
Contributor

@KR155E KR155E commented Jul 22, 2024

What it does

Fixes #13923

Makes the "core.saveAll" command check each file's isDirty flag instead of just blindly saving all open files.

How to test

  1. Open any file and aside to it, the Properties view
  2. Note the "Last modified" timestamp in the Properties view
  3. Run the command "File: Save All"
  4. Check the "Last modified" timestamp again in the Properties view (make sure to switch to another file and back to update the view first, it won't update automatically)

Follow-ups

Review checklist

Reminder for reviewers

Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me and works as expected, thank you very much for your contribution @KR155E!

Note that the CI has some issues with Node version < 18 but this is unrelated to this PR and is caused by #13903.

@martin-fleck-at martin-fleck-at merged commit 10f3ff4 into eclipse-theia:master Jul 22, 2024
11 of 14 checks passed
@sgraband sgraband added this to the 1.52.0 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Save All command blindly modifies all open files
3 participants