do not clear Task definition or scope unless execution changes #4304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elaihau
force-pushed
the
task_constructor
branch
from
3aa9e8e
to
6bcd886
Compare
- in the current Task class of the plugin-ext package, the "definition" and "scope" property are reset if any Task property gets updated. Since the "task definition" is only dependent on "task execution", this change updates the value of "task definition" if and only if "task execution" is changed. Signed-off-by: elaihau <[email protected]>
elaihau
force-pushed
the
task_constructor
branch
from
6bcd886
to
82b2547
Compare
RomanNikitenko
approved these changes
Feb 13, 2019
|
merged as the initial commit of #4216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: elaihau [email protected]