Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delay hosted plugins' initialization #4383

Merged
merged 2 commits into from
Feb 21, 2019
Merged

delay hosted plugins' initialization #4383

merged 2 commits into from
Feb 21, 2019

Commits on Feb 19, 2019

  1. delay hosted plugins' initialization 

    - When plugins query the `workspace.workspaceFolders`, Theia plugin api returns `undefined` when there is no workspace open, or the opened workspace has not been resolved by `WorkspaceService`. And this is inconsistent with vsCode, where the extension host is not started until the `initialize` function of `WorkspaceService` returns. This change delays the initialization and loading of plugins to ensure workspace root(s) are resolved beforehand.

Signed-off-by: elaihau <[email protected]>
    elaihau committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    1f2a507 View commit details
    Browse the repository at this point in the history

  2. setup plugin api before plugins are started 

    - in current Theia code plugins are loaded and activated before the plugin api becomes ready. This change fixes this problem.

Signed-off-by: elaihau <[email protected]>
    elaihau committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    8205249 View commit details
    Browse the repository at this point in the history