Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[file-search] add 'Clear Editor History' command #4392

Merged
merged 1 commit into from
Feb 22, 2019

Conversation

vince-fugnitto
Copy link
Member

Fixes #4389

  • If a user's recently opened editors list becomes large, there is no way to currently purge the list.
    The command helps solve that issue by clearing the location stack, and resetting the pointer.

Signed-off-by: Vincent Fugnitto [email protected]

@vince-fugnitto vince-fugnitto added the enhancement issues that are enhancements to current functionality - nice to haves label Feb 20, 2019
@vince-fugnitto
Copy link
Member Author

In order to visualise the change, you can perform the following steps:

  1. Ensure that your quick-open file has Recently Opened results ctrlcmd+p.
  2. Clear the editor history by calling ctrlcmd+shift+p and select Editor: Clear Editor History
  3. Check that Recently Opened results are empty.
  4. Check that the menu items Go > Back and Go > Forward are disabled.

@svenefftinge
Copy link
Contributor

Thanks, LGTM but I think @kittaakos should approve.

@kittaakos
Copy link
Contributor

should approve.

It seems there are broken tests due to Git.

Could not find Git on the PATH.

It did not happen yesterday. One has to look into the browser tests.

Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected. Thank you!

Fixes #4389

- If a user's recently opened editors list becomes large, there is no way to currently purge the list.
The command helps solve that issue by clearing the location stack, and resetting the pointer.

Signed-off-by: Vincent Fugnitto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants