Add missing git diff caption #4640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
reviewed
Mar 21, 2019
Fixes #4639 Currently, the `git-diff-widget` does not have a caption (tooltip). This means that when the widget is docked, and it's icon is displayed, no tooltip is shown when hovering while others widget do include it. For the sake of completeness and consistency, the `git-diff-widget` should include a caption. Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/git-diff-caption
branch
from
a6b89d4
to
80098fd
Compare
akosyakov
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4639
Currently, the
git-diff-widgetdoes not have a caption (tooltip).This means that when the widget is docked, and it's icon is displayed,
no tooltip is shown when hovering while others widget do include it.
For the sake of completeness and consistency, the
git-diff-widgetshould include a caption.
Signed-off-by: Vincent Fugnitto [email protected]