[plug-in] Bump VS Code API version #4745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ifb5f82e0f914a47ba2b0cbc7529452a9a0c68287 Signed-off-by: Florent Benoit <[email protected]>
evidolob
approved these changes
Mar 28, 2019
akosyakov
approved these changes
Mar 28, 2019
|
I don't think that VS Code extensions migrating to new APIs super fast. The main issue is this check for language extensions: https://github.com/Microsoft/vscode-languageserver-node/blob/07ea3961354ed0160d13e2830b9591f5fe1a8cfe/client/src/main.ts#L42 Looking at the history it also does not get updated super often, there are 4 and 7 months intervals. both 1.33 and 1.32 would work to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump VS Code API version to the latest
Fixes #4124
I will provide a way to override it through ENV Var later
I'm still wondering looking at microsoft/vscode#71059 if we should not bump it to 1.33.0 instead or move release lifecycle at the beginning of the month instead of the last thursday of the month to better match release lifecycle of VS Code. (else for one month we're behind of one version...)
Change-Id: Ifb5f82e0f914a47ba2b0cbc7529452a9a0c68287
Signed-off-by: Florent Benoit [email protected]