Update C/C++ grammars to files used by VSCode #6937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces excessive CPU usage on Windows and reducing latency for all Signed-off-by: Nigel Westbury <[email protected]>
- On Windows, `FileSearchService`.find now returns valid file URIs as it already did on linux. - Use LabelProvider to create tooltip field for quick open entries. - Allow Windows users to search for file paths using either '/' or '\\'.
Signed-off-by: Nigel Westbury <[email protected]>
Signed-off-by: Bogdan Stolojan <[email protected]> Renaming property Signed-off-by: Bogdan Stolojan <[email protected]>
Signed-off-by: Rob Moran <[email protected]>
Calling `contributionProvider.getContributions` in the constructor was throwing errors because some of the contributions inject the LabelProvider.
This allows toolbar items to show content specific to the current widget. For example, a toolbar item for the terminal could show a message specific to the currently displayed terminal tab. Signed-off-by: Matthew Gordon <[email protected]>
The previous implementation did not work because the window was unloaded before the dialog could be opened. This implementation gets around some… unusual behaviour of Electron's beforeunload event by using the will-prevent-unload WebContents event.
If a second instance is opened, it closes immediately and the original instance receives focus. Signed-off-by: Matthew Gordon <[email protected]>
Signed-off-by: Nigel Westbury <[email protected]>
Signed-off-by: Nigel Westbury <[email protected]> Clean up css class names and other code review changes
Signed-off-by: Nigel Westbury <[email protected]>
The version of TypeScript and @types/react used in mbs-ide are not compatible with the `event` type replaced by this commit. This commit can be reverted from ARMmbed/theia when: - Theia updates TS or @types/react such that the original code compiles - mbs-ide no longer uses @theia/scm in its workspace.
Shut down Mercurial command servers after 10 seconds of inactivity Clean out unneeded code Added test for HgCommandServer utils.
…er provider type.
Minor touches suggested by Kanthan
Signed-off-by: thegecko <[email protected]>
Signed-off-by: Federico Bozzini <[email protected]>
MessageService is not available outside of a connection container context, so using the default init would fail.
… 2166-hg-branches
IOTIDE 2166: hg branches
For Hg now WorkingDirectoryStatus.currentHead is Branch.tip.sha
Amend support does not work in many edge-cases, this disables amend for Hg leaving the code in-place inside HgScmProvider to be re-enabled when everything will be fixed.
Implemented Hg.createBranch() and removed Hg.checkout() after hg.createBranch() call.
* Fixed forget operation Signed-off-by: Federico Bozzini <[email protected]> * Substituted forget operation with discard Signed-off-by: Federico Bozzini <[email protected]> * Discard operation prevent from creating a backup file Signed-off-by: Federico Bozzini <[email protected]>
Signed-off-by: Rob Moran <[email protected]>
Signed-off-by: Federico Bozzini <[email protected]>
Signed-off-by: Rob Moran <[email protected]>
Fix repository switching in history view
|
I think this might have been mistakenly committed 🙈 |
|
@vince-fugnitto Yes, that was a mistake. It will be rebased on top of master Theia and then reopened :) |
Please note that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Update cpp package to use vscode grammar files as defined here:
https://github.com/jeff-hykin/cpp-textmate-grammar
https://github.com/microsoft/vscode/tree/master/extensions/cpp/syntaxes
How to test
Open a C/C++ file and enjoy a richer syntax colourisation.
Review checklist
Reminder for reviewers