Read snippets as plugin resources #8468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Mäder <[email protected]>
akosyakov
reviewed
Sep 4, 2020
| @@ -121,8 +122,9 @@ export class PluginSharedStyle { | |||
| } | |||
|
|
|||
| static toExternalIconUrl(iconUrl: string): string { | |||
| if (iconUrl.startsWith('hostedPlugin/')) { | |||
There was a problem hiding this comment.
we need to test for regressions in Electron, there should be a PR with How to test section before introducing it
akosyakov
added
electron
1 task
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
pluginresourceuri scheme that is used with snippet files initiallyPluginResourceandPluginResourceResolverthat can read content from plugin resource urlsHow to test
In Che, I can use the Java snippets to test: they should work before and after the Java plugin starts up. Also, stuff like reading icons for views (vscode-java-test, for example) should still work.
Review checklist
Reminder for reviewers