Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bpdm): add bpdm orchestrator roles and svc acc #1048

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

typecastcloud
Copy link
Contributor

Description

Add following BPDM technical user roles for CX Operator:

  • BPDM Orchestrator Admin
  • BPDM Orchestrator Task Creator
  • BPDM Orchestrator Processor Clean
  • BPDM Orchestrator Processor CleanAndSync
  • BPDM Orchestrator Processor PoolSync

Add BPDM service accounts for CX Operator:

  • sa-cl7-cx-1
  • sa-cl7-cx-7
  • sa-cl25-cx-1
  • sa-cl25-cx-2
  • sa-cl25-cx-3

Why

eclipse-tractusx/portal-iam#155 added new BPDM roles and service accounts. Adding these in seeding data allows for configuration via portal.

Issue

#1020

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@typecastcloud
Copy link
Contributor Author

Added test cases in issue:
#1020 (comment)

@typecastcloud typecastcloud marked this pull request as ready for review September 30, 2024 10:04
@typecastcloud typecastcloud self-assigned this Oct 2, 2024
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @typecastcloud thank you for the PR, awesome!
could you please rebase to main? IMO, that will solve the issue with the currently failing build https://github.com/eclipse-tractusx/portal-backend/actions/runs/11139606243/job/30956625767?pr=1048
could you please also change the PR title to feat(bpdm): add bpdm orchestrator roles and svc acc to follow conventional commits?

@typecastcloud typecastcloud changed the title feat(bpdm): 1020 bpdm orchestrator roles and svc acc feat(bpdm): add bpdm orchestrator roles and svc acc Oct 2, 2024
@typecastcloud typecastcloud force-pushed the feat/1020-bpdm-orchestrator-roles-and-svc-acc branch from ad90160 to 777b73d Compare October 2, 2024 11:04
Copy link

sonarcloud bot commented Oct 2, 2024

@typecastcloud
Copy link
Contributor Author

typecastcloud commented Oct 2, 2024

Hi @typecastcloud thank you for the PR, awesome! could you please rebase to main? IMO, that will solve the issue with the currently failing build https://github.com/eclipse-tractusx/portal-backend/actions/runs/11139606243/job/30956625767?pr=1048 could you please also change the PR title to feat(bpdm): add bpdm orchestrator roles and svc acc to follow conventional commits?

Title renamed and rebased. Still the same build issue.

When I run tests, order for /api/administration/registration/Network/companies in docs/api/administration-service.yaml changes.

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@ntruchsess could you please review again?

@evegufy
Copy link
Contributor

evegufy commented Oct 2, 2024

Hi @typecastcloud thank you for the PR, awesome! could you please rebase to main? IMO, that will solve the issue with the currently failing build https://github.com/eclipse-tractusx/portal-backend/actions/runs/11139606243/job/30956625767?pr=1048 could you please also change the PR title to feat(bpdm): add bpdm orchestrator roles and svc acc to follow conventional commits?

Title renamed and rebased. Still the same build issue.

When I run tests, order for /api/administration/registration/Network/companies in docs/api/administration-service.yaml changes.

GH workflow ran into a timeout at the first attempt, 2nd attempt was successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: IN PROGRESS
Development

Successfully merging this pull request may close these issues.

3 participants