Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sig#779 - Fix deprecated warnings in Storybook files #144

Closed
oyo opened this issue Apr 10, 2024 · 0 comments
Closed

sig#779 - Fix deprecated warnings in Storybook files #144

oyo opened this issue Apr 10, 2024 · 0 comments
Assignees
@oyo
Labels
bug Something isn't working
Milestone
Release 24.12

Comments

@oyo
Copy link
Contributor

oyo commented Apr 10, 2024 •
edited
Loading

Current Behavior

Storybook files show deprecated warnings after upgrade to major version 8.x.

Expected Behavior

No use of deprecated code in our codebase.

Steps To Reproduce

Linter checks for Storybook are currently disabled in this line
https://github.com/eclipse-tractusx/portal-shared-components/blob/main/.eslintrc.json#L2
remove the *.stories.* entry and run yarn lint.
Notice a lot of errors and warnings.
Migration guide to Storybook 8.x: https://storybook.js.org/docs/migration-guide
@oyo oyo added the bug Something isn't working label Apr 10, 2024
@evegufy evegufy mentioned this issue Apr 10, 2024
Closed
@evegufy evegufy mentioned this issue Jul 11, 2024
Open
@jjeroch jjeroch removed this from the Version CX Release 24.05 (dev) milestone Jul 19, 2024
@shahmargi12 shahmargi12 mentioned this issue Jul 24, 2024
Merged
3 tasks
evegufy pushed a commit that referenced this issue Aug 7, 2024
@shahmargi12 @oyo
fix: solve linting errors and warnings in storybook (#248)
6a2d5a8 
#144

---------

Co-authored-by: Martin Rohrmeier <[email protected]>
@MaximilianHauer MaximilianHauer added this to the Release 24.12 milestone Sep 6, 2024
@evegufy evegufy changed the title Fix deprecated warnings in Storybook files sig#779 - Fix deprecated warnings in Storybook files Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oyo oyo

Labels
bug Something isn't working
Projects
Portal
Archived in project
Milestone
Release 24.12
Development

No branches or pull requests
3 participants
@oyo @jjeroch @MaximilianHauer