Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema-to-html mojo as a replacement for ant ConvertSchemaToHTML #2969

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Oct 30, 2023

Currently platform build contains ant targets to run ConvertSchemaToHTML for documentation purpose.

This adds as a first step a new mojo
tycho-document-bundle-plugin:schema-to-html that offers the same functionality and should act as a base to further improve the brittle manually maintained references the current process requires and already allows to move things from the ant build to the maven build files.

Currently platform build contains ant targets to run ConvertSchemaToHTML
for documentation purpose.

This adds as a first step a new mojo
tycho-document-bundle-plugin:schema-to-html that offers the same
functionality and should act as a base to further improve the brittle
manually maintained references the current process requires and already
allows to move things from the ant build to the maven build files.
@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Oct 30, 2023
@laeubi
Copy link
Member Author

laeubi commented Oct 30, 2023

For further improvements we would need for example:

to also search schemas in dependencies.

@github-actions
Copy link

Test Results

   564 files  ±0     564 suites  ±0   4h 55m 55s ⏱️ + 20m 23s
   368 tests ±0     361 ✔️  - 1    6 💤 ±0  0 ±0  1 🔥 +1 
1 104 runs  ±0  1 084 ✔️  - 1  19 💤 ±0  0 ±0  1 🔥 +1 

For more details on these errors, see this check.

Results for commit abd0cd0. ± Comparison against base commit 9f95dc0.

@laeubi laeubi merged commit 4c276d9 into eclipse-tycho:master Oct 30, 2023
9 of 11 checks passed
@github-actions
Copy link

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@laeubi
Copy link
Member Author

laeubi commented Oct 30, 2023

With

we will be able to get rid of most of the copied code and can further develop this in PDE where the actual function belongs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant