Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve target definition variables during p2 repository assembly #3049

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

kysmith-csg
Copy link
Contributor

Recreation of #3042 to account for new base branch (master vs v4.0.x).

Copy link

Test Results

   570 files  ±0     570 suites  ±0   3h 48m 55s ⏱️ + 30m 7s
   374 tests ±0     368 ✔️ ±0    6 💤 ±0  0 ±0 
1 122 runs  ±0  1 103 ✔️ ±0  19 💤 ±0  0 ±0 

Results for commit 555fc3c. ± Comparison against base commit 73fb931.

Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.
Thank you.

@HannesWell HannesWell added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Nov 17, 2023
@HannesWell HannesWell merged commit 1c37754 into eclipse-tycho:master Nov 17, 2023
11 checks passed
Copy link

💔 All backports failed

Status Branch Result
tycho-4.0.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 3049

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@HannesWell
Copy link
Member

💔 All backports failed

Status Branch Result
❌ tycho-4.0.x Backport failed because of merge conflicts

OK, looks like this was a bad example to demonstrate the automated back-port feature. :/

Can you just re-open #3042 to handle the 'back-porting'?

@kysmith-csg
Copy link
Contributor Author

@HannesWell I am not able to reopen pull requests so I've opened #3051.

@HannesWell
Copy link
Member

@HannesWell I am not able to reopen pull requests so I've opened #3051.

Thanks.
From my experience one can only reopen a closed PR if the branch still exists and points to the exact commit it pointed last when the PR was closed. But additionally this might also require commiter rights (I'm not sure about that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants