Update RpcClient::invoke_method() to return a UMessage in support of symmetry / flexibility #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLeVasseur
changed the title
|
Amending this -- discussion with @stevenhartley came to the conclusion that we should use uP-L1 send() and register_listener() only for uStreamer operation to make us able to have a more generic implementation. However, returning a UMessage from uP-L2's invoke_method does give some symmetry and flexibility to the API. Looking to hear what folks have to think |
stevenhartley
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
@dakrbo & @sophokles73 let me know your thoughts, +1 from me
sophokles73
reviewed
Jan 30, 2024
|
Closing this one in favor of @AnotherDaniel's PR over here which does some more general clean up as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there 👋
As I worked on the uStreamer we figured out we'll need RpcClient::invoke_method() to return a UMessage in order to make the operations performed by the uStreamer upon the CEs coming in and out as generic as possible.
@stevenhartley put out a spec change and made the change over in up-java already. More details can be understood from there.