Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update HTTP caching #93

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

update HTTP caching #93

wants to merge 3 commits into from

Conversation

wzy1935
Copy link
Contributor

@wzy1935 wzy1935 commented Jul 18, 2024

Refers to issue #70.

Major changes in CacheFilter.java, implemented 1, 2, 3, 4, 5 (partial), 6, 8, 9.
(Implement 6 evolves with parts of 1 and 4 so they need to be done as well)

No test has been added/updated so far, so running the test will fail since the cache has different behaviors.

@wzy1935 wzy1935 force-pushed the issue/70 branch 2 times, most recently from 72b58bf to 1497105 Compare July 24, 2024 08:19
@wzy1935 wzy1935 marked this pull request as ready for review July 24, 2024 08:38
@tsegismont
Copy link
Contributor

The PR seems to contain a commit that is not related (caching SPI change). Correct? In this case, can you please rebase your branch on the main branch?

@wzy1935
Copy link
Contributor Author

wzy1935 commented Jul 24, 2024

It's somehow related since it uses the async version of the cache API. I think we could rebase this one after merging #92 (that one is in progress) ?

@tsegismont
Copy link
Contributor

It's somehow related since it uses the async version of the cache API. I think we could rebase this one after merging #92 (that one is in progress) ?

Does it require the Cache SPI changes or is it just because you started this PR off of your Cache SPI branch?

@wzy1935
Copy link
Contributor Author

wzy1935 commented Jul 24, 2024

I started it on the SPI branch - it can be reversed to the original cache API, but it will just look a bit different.

@tsegismont
Copy link
Contributor

I started it on the SPI branch - it can be reversed to the original cache API, but it will just look a bit different.

Then yes, it's fine to rebase this one after #92 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants