Update to removal of dummy vertx metrics

eclipse-vertx · Aug 11, 2024 · 195540d · 195540d
1 parent 2a2ca71
commit 195540d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/application/src/test/java/io/vertx/core/CustomMetricsFactory.java b/application/src/test/java/io/vertx/core/CustomMetricsFactory.java
@@ -13,7 +13,6 @@
 
 import io.vertx.core.json.JsonObject;
 import io.vertx.core.metrics.MetricsOptions;
-import io.vertx.core.metrics.impl.DummyVertxMetrics;
 import io.vertx.core.spi.VertxMetricsFactory;
 import io.vertx.core.spi.metrics.VertxMetrics;
 
@@ -22,9 +21,12 @@
  */
 public class CustomMetricsFactory implements VertxMetricsFactory {
 
+  public static final VertxMetrics DUMMY = new VertxMetrics() {
+  };
+
   @Override
   public VertxMetrics metrics(VertxOptions options) {
-    return DummyVertxMetrics.INSTANCE;
+    return DUMMY;
   }
 
   @Override

diff --git a/...cation/src/test/java/io/vertx/launcher/application/VertxApplicationExtensibilityTest.java b/...cation/src/test/java/io/vertx/launcher/application/VertxApplicationExtensibilityTest.java
@@ -16,7 +16,7 @@
 import io.vertx.core.VertxOptions;
 import io.vertx.core.internal.VertxInternal;
 import io.vertx.core.json.JsonObject;
-import io.vertx.core.metrics.impl.DummyVertxMetrics;
+import io.vertx.core.spi.metrics.VertxMetrics;
 import io.vertx.test.fakecluster.FakeClusterManager;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Test;
@@ -111,7 +111,7 @@ public void beforeStartingVertx(HookContext context) {
 
       @Override
       public VertxBuilder createVertxBuilder(VertxOptions options) {
-        return super.createVertxBuilder(options).withMetrics(o -> DummyVertxMetrics.INSTANCE);
+        return super.createVertxBuilder(options).withMetrics(o -> new VertxMetrics() {});
       }
     };
     TestVertxApplication app = new TestVertxApplication(new String[0], hooks);

diff --git a/cli/src/test/java/io/vertx/core/CustomMetricsFactory.java b/cli/src/test/java/io/vertx/core/CustomMetricsFactory.java
@@ -13,7 +13,6 @@
 
 import io.vertx.core.json.JsonObject;
 import io.vertx.core.metrics.MetricsOptions;
-import io.vertx.core.metrics.impl.DummyVertxMetrics;
 import io.vertx.core.spi.VertxMetricsFactory;
 import io.vertx.core.spi.metrics.VertxMetrics;
 
@@ -22,9 +21,12 @@
  */
 public class CustomMetricsFactory implements VertxMetricsFactory {
 
+  public static final VertxMetrics DUMMY = new VertxMetrics() {
+  };
+
   @Override
   public VertxMetrics metrics(VertxOptions options) {
-    return DummyVertxMetrics.INSTANCE;
+    return DUMMY;
   }
 
   @Override