Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Automatically label and close stale issues #763

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LukasWoodtli
Copy link
Contributor

This helps to keep the list of issues short and relevant.

Should we do some automatic clean-up tasks?

If yes: Should we also automatically close old PRs?

TODO: remove debug-only

This helps to keep the list of issues short and relevant.
@sbernard31
Copy link
Contributor

First, you are the most active committer on this project, so if you think it's a good idea, feel free to add this.

My 2 cts :

  • I'm not sure why an inactive old issue should be closed. I mean if there is an issue like "feature request", I'm not sure that inactivity is good reason to close it. FMPOV a good reason should be : "implemented", "out of scope", ...
  • If feature is in the scope but not the priority of the team it's fine to keep it open for a long time.
  • Maybe it makes more sense for PR but I still prefer issue/PR was closed manually with a real reason. From a contributor perspective, this is a bit frustrating to see an issue closed "automatically because inactivity".
  • I feel that for now there is no so much issue open by week and so this should be manageable manually.
  • For the current 74 issue and 14 PR opened, there is maybe very old issue which should be closed. So maybe it would be worth it to check it one by one and see if some of them should be closed or not. It's totally fine for some of them to put a message like "This issue was created before the revival of Wakaama 📢 Wakaama Revival ! 🏗 #488 and I'm not sure this issue/PR is still relevant because code base changed a lot, I close it but feel free to comment/reopen if this is still needed" (or something better but you see the idea 🙂 )

But again, If you prefer the automatic job, feel free to do that.

@LukasWoodtli
Copy link
Contributor Author

@mlasch @rettichschnidi What do you think about this.

days-before-issue-close: 365
stale-issue-label: "stale"
stale-issue-message: "This issue is stale because it has been open for a year with no activity."
close-issue-message: "This issue was closed because it has been inactive for a year since being marked as stale."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, if doing this (unsure if a good idea at all), then we should to change the language to be a bit more inviting.

E.g.

Suggested change
close-issue-message: "This issue was closed because it has been inactive for a year since being marked as stale."
close-issue-message: "This issue was closed because it has been inactive for a year since being marked as stale. Feel free to re-open this issue if it is still relevant to you."

And we should ensure the issue can actually be re-opened (by anyone).

@rettichschnidi rettichschnidi removed their assignment Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants