Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode 1.54 #618

Merged

Conversation

mickaelistria
Copy link
Contributor

Signed-off-by: Mickael Istria [email protected]

@mickaelistria
Copy link
Contributor Author

VSCode ships newer major version of the vscode-json-languageservice so it's not compatible with yaml-language-server any more and requires to duplicate multiple version of libraries, leading to path too long. I suggest we simply wait for yaml-language-server to use newer major of vscode-json-language server before updating VSCode.

@akurtakov
Copy link
Contributor

Sounds good. Please open issue for yaml-language-server so we know what exactly we wait for.

@mickaelistria
Copy link
Contributor Author

+ yaml-language-server 0.16.0
+ chrome-debug-adapter 4.12.12

Signed-off-by: Mickael Istria <[email protected]>
@mickaelistria
Copy link
Contributor Author

Submitted CQs http://dev.eclipse.org/ipzilla/show_bug.cgi?id=23161 and http://dev.eclipse.org/ipzilla/show_bug.cgi?id=23160 , other deps are approved by dash-license tool.
Let's merge (CQ only prevent release, not merge).

@mickaelistria mickaelistria merged commit 85ab96e into eclipse-wildwebdeveloper:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants