Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new repository for hosting the WindowBuilder website sources #2

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

ptziegler
Copy link
Contributor

With the deprecation of PHP within the current year, we need to migrate HTML or something similar. Hugo is one of the proposed alternative, which requires its sources to be hosted separately from the actual website.

Issue:
https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1934

Hugo template:
https://gitlab.eclipse.org/eclipsefdn/it/webdev/hugo-eclipsefdn-website-boilerplate#how-to-build-my-projects-website-with-jenkins

"Old" website:
https://github.com/eclipse-windowbuilder/windowbuilder-website/

@ptziegler ptziegler requested review from a team as code owners February 9, 2024 18:15

This comment has been minimized.

With the deprecation of PHP within the current year, we need to migrate
HTML or something similar. Hugo is one of the proposed alternative,
which requires its sources to be hosted separately from the actual
website.

Issue:
https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1934

Hugo template:
https://gitlab.eclipse.org/eclipsefdn/it/webdev/hugo-eclipsefdn-website-boilerplate#how-to-build-my-projects-website-with-jenkins

"Old" website:
https://github.com/eclipse-windowbuilder/windowbuilder-website/
Copy link

github-actions bot commented Feb 9, 2024

Diff for 192a582:
Printing local diff:

Actions are indicated with the following symbols:
+   create
!   modify
!   forced update
-   delete

Organization tools.windowbuilder[id=eclipse-windowbuilder]
  there have been 1 validation infos, enable verbose output with '-v' to to display them.

+   add repository[name="windowbuilder-website-source"] {
+     allow_auto_merge                  = false
+     allow_forking                     = true
+     allow_merge_commit                = true
+     allow_rebase_merge                = true
+     allow_squash_merge                = true
+     allow_update_branch               = false
+     archived                          = false
+     default_branch                    = "master"
+     delete_branch_on_merge            = false
+     dependabot_alerts_enabled         = true
+     dependabot_security_updates_enabled = false
+     description                       = null
+     gh_pages_build_type               = "disabled"
+     has_discussions                   = false
+     has_issues                        = true
+     has_projects                      = true
+     has_wiki                          = true
+     homepage                          = null
+     is_template                       = false
+     merge_commit_message              = "PR_TITLE"
+     merge_commit_title                = "MERGE_MESSAGE"
+     name                              = "windowbuilder-website-source"
+     private                           = false
+     secret_scanning                   = "enabled"
+     secret_scanning_push_protection   = "disabled"
+     squash_merge_commit_message       = "COMMIT_MESSAGES"
+     squash_merge_commit_title         = "COMMIT_OR_PR_TITLE"
+     template_repository               = null
+     topics                            = []
+     web_commit_signoff_required       = false
+   }

+   add repo_workflow_settings[repository="windowbuilder-website-source"] {
+     enabled                           = false
+   }
  
  Plan: 2 to add, 0 to change, 0 to delete.
Canonical Diff for 192a582:
Showing canonical diff:

Organization tools.windowbuilder[id=eclipse-windowbuilder]

--- canonical
+++ original
@@ -9,7 +9,6 @@
       secret_scanning_push_protection: "disabled"
       web_commit_signoff_required: false
       workflows+: {
-        actions_can_approve_pull_request_reviews: false
         default_workflow_permissions: "write"
       }
     }
@@ -24,7 +23,6 @@
       secret_scanning_push_protection: "disabled"
       web_commit_signoff_required: false
       workflows+: {
-        actions_can_approve_pull_request_reviews: false
         default_workflow_permissions: "write"
       }
     }

@netomi
Copy link
Contributor

netomi commented Feb 9, 2024

I can approve but I am wondering why workflows are disabled for the repo, I would expect that you need to build it somehow but you can change it later I guess.

@netomi netomi merged commit b8823af into eclipse-windowbuilder:main Feb 9, 2024
2 checks passed
@netomi
Copy link
Contributor

netomi commented Feb 9, 2024

changes are live.

@ptziegler ptziegler deleted the website-source branch February 10, 2024 18:22
@ptziegler
Copy link
Contributor Author

I can approve but I am wondering why workflows are disabled for the repo, I would expect that you need to build it somehow but you can change it later I guess.

Thanks!
To be honest, I initially only copied the configuration for the windowbuilder-website repository. And I think for the initial migration, it makes sense to have the automatic deployment disable in order to avoid accidentally pushing a broken website.

Until then, I can always run the upcoming Jenkins job manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants