-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade spock to 2.3 and groovy to 3.0.19 #1263
Conversation
1fb4ac4
to
961a884
Compare
update groovy to 3.0.19 and spock to 2.3
961a884
to
ca44cf3
Compare
e16ade0
to
82f78c7
Compare
0a5abed
to
5d82c5c
Compare
Did all these changes been ip approved by e.g. https://github.com/eclipse/dash-licenses/ ? I'm trying to move Jdt.ls to latest buildship and face a license issue eclipse-jdtls/eclipse.jdt.ls#2974 . |
Groovy and Spock are test-only dependencies and they should not appear anywhere in production. |
My bad I wanted to ask for org.gradle.toolingapi. No idea why I actually asked at this PR. |
All right. Regarding the org.gradle.toolingapi dependency: years ago the Eclipse IP team allowed us to update the tapi versions without an explicit license review. |
@waynebeaton Can this permission be somehow handled in the dash tool database or the tool itself so buildship downstreams can rely on dash licensetool? |
The easiest thing to do is to remove the the component from the information that you pass to the tool. For the Maven plugin, you can use the In the meantime, I have a prototype extension that should help us find new versions of the source. |
@donat where do I find downloads (especially of source) of I'm looking specifically for some kind of archive format, not a pointer to the source tree in a Git repository (I can make the latter work, but an archive file is better for a couple of reasons). Scanning these should be easy enough, so I'd like to set us up for future success (other projects have asked for this dependency). In the meantime... I grabbed the ZIP of the source from the Eclipse Buildship project; we'll use that to push through the review of this version. |
The source jar is available here: gradle-tooling-api-8.1.1-sources.jar |
Thanks. In the future, the IPLab scanner will look on repo.gradle.org for source for this and other |
No description provided.