CHE-3609: Create visual Git history window instead of old one #3799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhukovs
reviewed
Jan 18, 2017
| @@ -98,6 +101,25 @@ public final void writeTo(OutputStream out) throws IOException { | |||
| } | |||
| } | |||
|
|
|||
| private List<DiffEntry> EmptyToCommit(String commitId, DiffFormatter formatter) throws IOException { | |||
There was a problem hiding this comment.
EmptyToCommit method name should starts with lowercase
| @@ -98,6 +101,25 @@ public final void writeTo(OutputStream out) throws IOException { | |||
| } | |||
| } | |||
|
|
|||
| private List<DiffEntry> EmptyToCommit(String commitId, DiffFormatter formatter) throws IOException { | |||
| ObjectId commit = repository.resolve(commitId); | |||
| if (commit == null) { | |||
There was a problem hiding this comment.
FYI, guava has utility method com.google.common.base.Preconditions#checkArgument(boolean, java.lang.Object)
|
|
||
| service.diff(appContext.getDevMachine(), project.getLocation(), filePatterns, RAW, false, 0, revision.getId(), isCached) | ||
| .then(new Operation<String>() { | ||
| private void FetchRevisions() { |
There was a problem hiding this comment.
Method name should starts with lowercase letter.
| @@ -46,6 +45,7 @@ | |||
| @Singleton | |||
| public class ResetToCommitPresenter implements ResetToCommitView.ActionDelegate { | |||
| public static final String RESET_COMMAND_NAME = "Git reset to commit"; | |||
| public static final String LOG_COMMAND_NAME = "Git log"; | |||
|
Other seems ok |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1680/ |
vzhukovs
approved these changes
Jan 19, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1685/ |
vparfonov
approved these changes
Jan 20, 2017
slemeur
added
the
kind/enhancement
9 tasks
This was referenced Mar 1, 2017
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add new visual Git history window instead of old one.
What issues does this PR fix or reference?
#3609
Changelog
Git history panel changed to a window to enable visualization of commit changes.
Release Notes
We've replaced the git history panel with a new window. This allows you to see the changes from each commit visually with a diff viewer. You can get to the git history from the git menu, or you can right-click on a file in the project explorer and select git history from the context menu.
The git history window will show you all the commits:
Double clicking on a revision item, or clicking the 'Compare' button will open the visual diff viewer:
Tests written?
Yes