[cli] Improve UX of graceful shutdown message #4064
Conversation
benoitf
added
kind/enhancement
benoitf
requested review from
TylerJewell,
garagatyi,
bmicklea and
mshaposhnik
|
Build # 1911 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1911/ to view the results. |
|
@garagatyi I mentioned you if you wanted to check it was now working as you're expecting based the issue you reported. |
- base scripts : catch error code of action lifecycle and return it - cha-lib : return error code based on http error code - display better message when auth is required - skip graceful mode when repo is mounted Change-Id: I1ad021426444b5b4d880df518512e53ef4828336 Signed-off-by: Florent BENOIT <[email protected]>
| @@ -29,13 +29,23 @@ cmd_stop() { | |||
| FORCE_STOP=false | |||
| if [[ "$@" == *"--skip:graceful"* ]]; then | |||
| FORCE_STOP=true | |||
| elif local_repo; then | |||
| warning "Development mode [skip graceful stop]" | |||
There was a problem hiding this comment.
Why do you do this for local_repo, but not local_assembly?
There was a problem hiding this comment.
In the issue ppl were asking for local repo mode
I'm also ok for local_assembly. I will add
| cmd_lifecycle action "graceful-stop" "$@" >> "${LOGS}" 2>&1 || GRACEFUL_STATUS_RESULT=$? | ||
| # error on authentication (401 modulo 256 = 145) | ||
| if [[ ${GRACEFUL_STATUS_RESULT} -eq 145 ]]; then | ||
| error "Authentication failed on the system. Please provide --user and -password values or user --skip:graceful to bypass graceful stop." |
There was a problem hiding this comment.
"Authentication failed during graceful shutdown (hint: --skip:graceful to bypass)"
There was a problem hiding this comment.
@TylerJewell in the issue it was requested to provide the argument for authentication (--user and --password) when auth is required
| error "Authentication failed on the system. Please provide --user and -password values or user --skip:graceful to bypass graceful stop." | ||
| return 2; | ||
| elif [[ ${GRACEFUL_STATUS_RESULT} -ne 0 ]]; then | ||
| error "We encountered an error -- see $CHE_HOST_CONFIG/cli.log. Graceful stop can be skipped with --skip:graceful" |
There was a problem hiding this comment.
"We encountered an error during graceful stop - see $CHE_HOST_CONFIG/cli.log."
There was a problem hiding this comment.
shouldn't we add the hint on the fact that graceful stop can be skipped ?
There was a problem hiding this comment.
If you do it have it as (hint: --skip:graceful does not wait for workspace stop)
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1944/ |
…ipts : catch error code of action lifecycle and return it - cha-lib : return error code based on http error code - display better message when auth is required - skip graceful mode when repo is mounted Change-Id: I4e89605fd3c42ad6ba02115c32297d16f49b3ffe Signed-off-by: Florent BENOIT <[email protected]>
…ipts : catch error code of action lifecycle and return it - cha-lib : return error code based on http error code - display better message when auth is required - skip graceful mode when repo is mounted Change-Id: Icc0caeb4db3dc3a1be802de95bb1f1d505f93b40 Signed-off-by: Florent BENOIT <[email protected]>
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1952/ |
|
@TylerJewell updated |
benoitf
removed
the
status/code-review
* Fix eclipse-che#1682 : Improve UX of graceful shutdown message - base scripts : catch error code of action lifecycle and return it - cha-lib : return error code based on http error code - display better message when auth is required - skip graceful mode when repo is mounted Change-Id: I1ad021426444b5b4d880df518512e53ef4828336 Signed-off-by: Florent BENOIT <[email protected]>
What does this PR do?
Improve UX of graceful shutdown message
What issues does this PR fix or reference?
codenvy/codenvy#1682
Changelog
Improves UX of graceful shutdown message.
Release Notes
We have made improvements to the CLI graceful shutdown behavior to catch additional errors, communicate more clearly when authentication is required for stop and skip the graceful mode when a repo is mounted.
Docs PR
n/a (improvement on UX, command is the same)
Change-Id: I1ad021426444b5b4d880df518512e53ef4828336
Signed-off-by: Florent BENOIT [email protected]